Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1556873003: Fix include presubmit warning in Wow64.cc (Closed)

Created:
4 years, 11 months ago by tapted
Modified:
4 years, 11 months ago
Reviewers:
Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix include presubmit warning in Wow64.cc Changes to Wow64.cc currently trigger: ** Presubmit Warnings ** Your #include order seems to be broken /* snip */ sandbox/win/src/Wow64.cc:11: - line belongs before previous line This is because the #include line for its corresponding header is spelled with a lowercase "w" in "wow64.h". Changing the #include to Wow64.h is the correct fix. Since the files themselves do not require renaming this shouldn't cause any case sensitivity filesystem confusion on the bots (I hope). BUG=None Committed: https://crrev.com/5364cc029e0a86bd3303a56d069fa8ee9d2235e1 Cr-Commit-Position: refs/heads/master@{#367301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sandbox/win/src/Wow64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Will Harris
lgtm
4 years, 11 months ago (2016-01-04 10:24:48 UTC) #3
tapted
Thanks! (and whoops - forgot to publish before I left work :)
4 years, 11 months ago (2016-01-04 10:30:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556873003/1
4 years, 11 months ago (2016-01-04 10:31:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 10:35:26 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 10:36:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5364cc029e0a86bd3303a56d069fa8ee9d2235e1
Cr-Commit-Position: refs/heads/master@{#367301}

Powered by Google App Engine
This is Rietveld 408576698