Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1556843002: Revert of mac and ios: Build third-party code with -Wall. (Closed)

Created:
4 years, 11 months ago by Geoff Lang
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac and ios: Build third-party code with -Wall. (patchset #2 id:20001 of https://codereview.chromium.org/1555843002/ ) Reason for revert: Fails compilation on Mac GPU bots. Original issue's description: > mac and ios: Build third-party code with -Wall. > > This lands the mac and ios build/common.gypi bits of > https://codereview.chromium.org/1551753002/ (reviewed there) > > BUG=573250 > R=thestig@chromium.org > TBR=thestig@chromium.org > > Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc > Cr-Commit-Position: refs/heads/master@{#367255} > > Committed: https://crrev.com/de5c041e67fa5abee83359b9346ca4896f1723ca > Cr-Commit-Position: refs/heads/master@{#367263} TBR=thestig@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=573250 Committed: https://crrev.com/6f0ae110927c19c75dac785887d56dc61c90abc5 Cr-Commit-Position: refs/heads/master@{#367267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/class-dump/class-dump.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Geoff Lang
Created Revert of mac and ios: Build third-party code with -Wall.
4 years, 11 months ago (2016-01-01 23:03:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556843002/1
4 years, 11 months ago (2016-01-01 23:03:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-01 23:04:26 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6f0ae110927c19c75dac785887d56dc61c90abc5 Cr-Commit-Position: refs/heads/master@{#367267}
4 years, 11 months ago (2016-01-01 23:05:39 UTC) #5
Geoff Lang
4 years, 11 months ago (2016-01-01 23:14:24 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1554923002/ by geofflang@chromium.org.

The reason for reverting is: thakis@ plans to address the failing bots..

Powered by Google App Engine
This is Rietveld 408576698