Issue 155681: Merge r2492 and r2493 to branches/1.2. This doesn't change the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155681: Merge r2492 and r2493 to branches/1.2. This doesn't change the... (Closed)

Created:
11 years, 5 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/1.2/

Visibility:
Public.

Merge r2492, r2493, and r2494 to branches/1.2. This doesn't change the behavior of V8, but it avoids subtle compilation/linking issues on Mac OS; see http://code.google.com/p/v8/issues/detail?id=404. Committed: http://code.google.com/p/v8/source/detail?r=2495

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -31 lines)			Patch
M	src/SConscript	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/register-allocator-arm-inl.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/frame-element.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
A +	src/frame-element.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/ia32/register-allocator-ia32-inl.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/parser.cc	View		2 chunks	+9 lines, -6 lines	0 comments	Download
M	src/register-allocator.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	src/register-allocator.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/register-allocator-x64-inl.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/v8.xcodeproj/project.pbxproj	View		5 chunks	+8 lines, -0 lines	0 comments	Download
M	tools/visual_studio/v8_base.vcproj	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	tools/visual_studio/v8_base_arm.vcproj	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Kevin Millikin (Chromium)

LGTM, with the 5 other occurrences of 'static' in inlined functions in register-allocator-{ia32,arm,x64}-inl.h changed to ...

11 years, 5 months ago (2009-07-17 08:19:38 UTC) #2

That's tight.