Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1219)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java

Issue 1556733002: Restore scrolloffset after exiting fullscreen. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: restore only when the page scale factor is back to the initial value Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java b/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java
index 78160f465ee353c8b268724758e7abb1b732a17d..5cd0a5ffe23520289ce5d896911500a768392aec 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwScrollOffsetManager.java
@@ -59,10 +59,6 @@ public class AwScrollOffsetManager {
private final Delegate mDelegate;
- // Scroll offset as seen by the native side.
- private int mNativeScrollX;
- private int mNativeScrollY;
-
// How many pixels can we scroll in a given direction.
private int mMaxHorizontalScrollOffset;
private int mMaxVerticalScrollOffset;
@@ -150,9 +146,6 @@ public class AwScrollOffsetManager {
// Called by the native side to scroll the container view.
public void scrollContainerViewTo(int x, int y) {
- mNativeScrollX = x;
- mNativeScrollY = y;
-
final int scrollX = mDelegate.getContainerViewScrollX();
final int scrollY = mDelegate.getContainerViewScrollY();
final int deltaX = x - scrollX;
@@ -238,13 +231,8 @@ public class AwScrollOffsetManager {
return;
}
- if (x == mNativeScrollX && y == mNativeScrollY) return;
-
- // The scrollNativeTo call should be a simple store, so it's OK to assume it always
- // succeeds.
- mNativeScrollX = x;
- mNativeScrollY = y;
-
+ // This will be a no-op if the delegate finds out it will scroll to the
+ // same offset in CSS pixel.
mDelegate.scrollNativeTo(x, y);
}
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698