Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 155672: Set window icon on options dialog, bookmark manager.... (Closed)

Created:
11 years, 5 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Evan Martin, mattm
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Set window icon on options dialog, bookmark manager. BUG=16951 TEST=launch bookmark manager on gnome/metacity, observe that window has icon Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M chrome/browser/gtk/bookmark_manager_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/gtk/options/options_window_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/gtk_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/gtk_util.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
11 years, 5 months ago (2009-07-17 02:20:16 UTC) #1
Evan Martin
11 years, 5 months ago (2009-07-17 02:23:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698