Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 15567002: Added support for running dart2js tests on android devices (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 329d087b80feb417a6ca9765182c4295a9c1a166..38fd5eef1482e277927b35afca912d7ae7fca378 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -468,7 +468,7 @@ class StandardTestSuite extends TestSuite {
recursive: true);
}
- Collection<Uri> get dart2JsBootstrapDependencies {
+ List<Uri> get dart2JsBootstrapDependencies {
if (!useSdk) return [];
var snapshotPath = TestUtils.absolutePath(new Path(buildDir).join(
@@ -853,7 +853,8 @@ class StandardTestSuite extends TestSuite {
crossOriginPort = configuration['_servers_'].crossOriginPort;
}
- var url= 'http://127.0.0.1:$serverPort$pathComponent'
+ var local_ip = configuration['local_ip'];
+ var url= 'http://$local_ip:$serverPort$pathComponent'
'?crossOriginPort=$crossOriginPort';
if (info.optionsFromFile['isMultiHtmlTest'] && subtestNames.length > 0) {
url= '${url}&group=${subtestNames[subtestIndex]}';
@@ -872,6 +873,7 @@ class StandardTestSuite extends TestSuite {
dartWrapper.closeSync();
}
+
/**
* The [StandardTestSuite] has support for tests that
* compile a test from Dart to JavaScript, and then run the resulting
@@ -975,6 +977,7 @@ class StandardTestSuite extends TestSuite {
}
}
+
// Variables for browser multi-tests.
List<String> subtestNames = info.optionsFromFile['subtestNames'];
TestCase multitestParentTest;
@@ -1679,7 +1682,7 @@ class LastModifiedCache {
_cache[uri.path] = file.existsSync() ? file.lastModifiedSync() : null;
return _cache[uri.path];
}
- return new Date.now();
+ return new DateTime.now();
}
}
@@ -1812,7 +1815,8 @@ class TestUtils {
'safari',
'opera',
'chrome',
- 'ff'
+ 'ff',
+ 'chromeOnAndroid',
];
return BROWSERS.contains(runtime);
}
« tools/testing/dart/browser_controller.dart ('K') | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698