Added support for running dart2js tests on android devices

tools/testing/dart/test_options.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test_options_parser;
 
 import "dart:io";
 import "dart:math";
 import "drt_updater.dart";
 import "test_suite.dart";
@@ skipping 56 matching lines @@
               '''Specify any compilation step (if needed).
 
    none: Do not compile the Dart code (run native Dart code on the VM).
          (only valid with the following runtimes: vm, drt)
 
    dart2dart: Compile Dart code to Dart code
               (only valid with the following runtimes: vm, drt)
 
    dart2js: Compile dart code to JavaScript by running dart2js.
          (only valid with the following runtimes: d8, drt, chrome,
-         safari, ie9, ie10, firefox, opera, none (compile only)),
+         safari, ie9, ie10, firefox, opera, chromeOnAndroid,
+         none (compile only)),
 
    dartc: Perform static analysis on Dart code by running dartc.
           (only valid with the following runtimes: none),
 
    dartanalyzer: Perform static analysis on Dart code by running the analyzer.
           (only valid with the following runtimes: none)''',
               ['-c', '--compiler'],
               ['none', 'dart2dart', 'dart2js', 'dartc', 'dartanalyzer'],
               'none'),
           new _TestOptionSpecification(
               'runtime',
               '''Where the tests should be run.
     vm: Run Dart code on the standalone dart vm.
 
     d8: Run JavaScript from the command line using v8.
 
     jsshell: Run JavaScript from the command line using firefox js-shell.
 
     drt: Run Dart or JavaScript in the headless version of Chrome,
          DumpRenderTree.
 
     dartium: Run Dart or JavaScript in Dartium.
 
-    [ff | chrome | safari | ie9 | ie10 | opera]: Run JavaScript in the specified
-         browser.
+    [ff | chrome | safari | ie9 | ie10 | opera | chromeOnAndroid]:
+        Run JavaScript in the specified browser.
 
     none: No runtime, compile only (for example, used for dartc static analysis
           tests).''',
               ['-r', '--runtime'],
               ['vm', 'd8', 'jsshell', 'drt', 'dartium', 'ff', 'firefox',
-               'chrome', 'safari', 'ie9', 'ie10', 'opera', 'none'],
+               'chrome', 'safari', 'ie9', 'ie10', 'opera', 'chromeOnAndroid', 'none'],
               'vm'),
           new _TestOptionSpecification(
               'arch',
               'The architecture to run tests for',
               ['-a', '--arch'],
               ['all', 'ia32', 'x64', 'simarm', 'simmips'],
               'ia32'),
           new _TestOptionSpecification(
               'system',
               'The operating system to run tests on',
@@ skipping 183 matching lines @@
               false,
               'bool'
               ),
           new _TestOptionSpecification(
               'use_browser_controller',
               'Use the new selenium replacement browser-controller.',
               ['--use_browser_controller'],
               [],
               false,
               'bool'
-              ),];
+              ),
+          new _TestOptionSpecification(
+              'local_ip',
+              'IP address the http servers should listen on.'
+              'This address is also used for browsers to connect.',
+              ['--local_ip'],
+              [],
+              '127.0.0.1'),];

[ricow1, 2013/05/21 18:30:43]

you actually default to 0.0.0.0 in the http server

[kustermann, 2013/05/22 09:30:58]

I'm aware and there is a reason for it:
- We don't want to expose (part of) the filesystem to all other people on the
network by default.

Here's why I did it in http_server.dart:
- If people get a failure message they get a list of commands they've to
execute. The http server command currently doesn't specify the ip to use (so it
takes 127.0.0.1) but the phone can't connect there.

Tough, it's not particularly nice.

   }
 
 
   /**
    * Parse a list of strings as test options.
    *
    * Returns a list of configurations in which to run the
    * tests. Configurations are maps mapping from option keys to
    * values. When encountering the first non-option string, the rest
    * of the arguments are stored in the returned Map under the 'rest'
@@ skipping 117 matching lines @@
     bool isValid = true;
     List<String> validRuntimes;
     switch (config['compiler']) {
       case 'dart2js':
         // Note: by adding 'none' as a configuration, if the user
         // runs test.py -c dart2js -r drt,none the dart2js_none and
         // dart2js_drt will be duplicating work. If later we don't need 'none'
         // with dart2js, we should remove it from here.
         validRuntimes = const ['d8', 'jsshell', 'drt', 'none', 'dartium',
                                'ff', 'chrome', 'safari', 'ie9', 'ie10',
-                               'opera'];
+                               'opera', 'chromeOnAndroid'];
         break;
       case 'dartc':
       case 'dartanalyzer':
         validRuntimes = const ['none'];
         break;
       case 'none':
       case 'dart2dart':
         validRuntimes = const ['vm', 'drt', 'dartium'];
         break;
     }
@@ skipping 147 matching lines @@
           timeout = 60;
           if (configuration['mode'] == 'debug') {
             timeout *= 8;
           }
           if (configuration['host_checked']) {
             timeout *= 16;
           }
           if (configuration['checked']) {
             timeout *= 2;
           }
-
           break;
         default:
           if (configuration['mode'] == 'debug') {
             timeout *= 2;
           }
           if (const ['drt', 'dartium'].contains(configuration['runtime'])) {
             timeout *= 4; // Allow additional time for browser testing to run.
           }
           break;
       }
@@ skipping 71 matching lines @@
         return option;
       }
     }
     print('Unknown test option $name');
     exit(1);
   }
 
 
   List<_TestOptionSpecification> _options;
 }