base/callback_list_unittest.nc - Issue 1556683003: Fix no-compile base_unittests for base::Pass() -> std::move conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/callback_list_unittest.nc

Issue 1556683003: Fix no-compile base_unittests for base::Pass() -> std::move conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/callback_list_unittest.nc

diff --git a/base/callback_list_unittest.nc b/base/callback_list_unittest.nc

index 45ac994f23906f768ceb6d3b449aa6333b0c8ff6..eb1d28043ed30b1ee50aa38810d33edfda25f6a1 100644

--- a/base/callback_list_unittest.nc

+++ b/base/callback_list_unittest.nc

@@ -24,7 +24,7 @@ class FooListener {

public:

FooListener() {}

- void GotAScopedFoo(scoped_ptr<Foo> f) { foo_ = f.Pass(); }

+ void GotAScopedFoo(scoped_ptr<Foo> f) { foo_ = std::move(f); }

dcheng 2015/12/31 10:24:53 #include <utility>

tzik 2015/12/31 11:10:46 Done.

scoped_ptr<Foo> foo_;

« no previous file with comments | « no previous file | base/memory/scoped_ptr_unittest.nc » ('j') | base/memory/scoped_ptr_unittest.nc » ('J')