Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1556683003:
Fix no-compile base_unittests for base::Pass() -> std::move conversion (Closed)
DescriptionFix no-compile base_unittests for base::Pass() -> std::move conversion
BUG=557422
TEST=gn gen out/Release --args="enable_nocompile_tests=true" && ninja -C out/Release base_nocompile_tests
Committed: https://crrev.com/a6e26be9e9ddddc988d547a1e95c5952832a9198
Cr-Commit-Position: refs/heads/master@{#367467}
Patch Set 1 #
Total comments: 4
Patch Set 2 : +#include #
Total comments: 2
Patch Set 3 : remove unneeded std::move #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== Fix no-compile base_unittests for base::Pass() -> std::move conversion BUG=557422 ========== to ========== Fix no-compile base_unittests for base::Pass() -> std::move conversion BUG=557422 TEST=gn gen out/Release --args="enable_nocompile_tests=true" && ninja -C out/Release base_nocompile_tests ==========
tzik@chromium.org changed reviewers: + dcheng@chromium.org
PTAL
LGTM with comments addressed. Sorry for breaking this https://codereview.chromium.org/1556683003/diff/1/base/callback_list_unittest.nc File base/callback_list_unittest.nc (right): https://codereview.chromium.org/1556683003/diff/1/base/callback_list_unittest... base/callback_list_unittest.nc:27: void GotAScopedFoo(scoped_ptr<Foo> f) { foo_ = std::move(f); } #include <utility> https://codereview.chromium.org/1556683003/diff/1/base/memory/scoped_ptr_unit... File base/memory/scoped_ptr_unittest.nc (right): https://codereview.chromium.org/1556683003/diff/1/base/memory/scoped_ptr_unit... base/memory/scoped_ptr_unittest.nc:28: return std::move(object); #include <utility>
https://codereview.chromium.org/1556683003/diff/1/base/callback_list_unittest.nc File base/callback_list_unittest.nc (right): https://codereview.chromium.org/1556683003/diff/1/base/callback_list_unittest... base/callback_list_unittest.nc:27: void GotAScopedFoo(scoped_ptr<Foo> f) { foo_ = std::move(f); } On 2015/12/31 10:24:53, dcheng wrote: > #include <utility> Done. https://codereview.chromium.org/1556683003/diff/1/base/memory/scoped_ptr_unit... File base/memory/scoped_ptr_unittest.nc (right): https://codereview.chromium.org/1556683003/diff/1/base/memory/scoped_ptr_unit... base/memory/scoped_ptr_unittest.nc:28: return std::move(object); On 2015/12/31 10:24:53, dcheng wrote: > #include <utility> Done.
The CQ bit was checked by tzik@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/1556683003/#ps20001 (title: "+#include")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556683003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556683003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
tzik@chromium.org changed reviewers: + danakj@chromium.org
+Dana for OWNER review. PTAL.
LGTM https://codereview.chromium.org/1556683003/diff/20001/base/memory/scoped_ptr_... File base/memory/scoped_ptr_unittest.nc (right): https://codereview.chromium.org/1556683003/diff/20001/base/memory/scoped_ptr_... base/memory/scoped_ptr_unittest.nc:31: return std::move(object); just return object, right?
https://codereview.chromium.org/1556683003/diff/20001/base/memory/scoped_ptr_... File base/memory/scoped_ptr_unittest.nc (right): https://codereview.chromium.org/1556683003/diff/20001/base/memory/scoped_ptr_... base/memory/scoped_ptr_unittest.nc:31: return std::move(object); On 2016/01/04 21:03:43, danakj (behind on reviews) wrote: > just return object, right? Right, I overlooked it. Removed std::move here.
The CQ bit was checked by tzik@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org, dcheng@chromium.org Link to the patchset: https://codereview.chromium.org/1556683003/#ps40001 (title: "remove unneeded std::move")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556683003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556683003/40001
Message was sent while issue was closed.
Description was changed from ========== Fix no-compile base_unittests for base::Pass() -> std::move conversion BUG=557422 TEST=gn gen out/Release --args="enable_nocompile_tests=true" && ninja -C out/Release base_nocompile_tests ========== to ========== Fix no-compile base_unittests for base::Pass() -> std::move conversion BUG=557422 TEST=gn gen out/Release --args="enable_nocompile_tests=true" && ninja -C out/Release base_nocompile_tests ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix no-compile base_unittests for base::Pass() -> std::move conversion BUG=557422 TEST=gn gen out/Release --args="enable_nocompile_tests=true" && ninja -C out/Release base_nocompile_tests ========== to ========== Fix no-compile base_unittests for base::Pass() -> std::move conversion BUG=557422 TEST=gn gen out/Release --args="enable_nocompile_tests=true" && ninja -C out/Release base_nocompile_tests Committed: https://crrev.com/a6e26be9e9ddddc988d547a1e95c5952832a9198 Cr-Commit-Position: refs/heads/master@{#367467} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a6e26be9e9ddddc988d547a1e95c5952832a9198 Cr-Commit-Position: refs/heads/master@{#367467} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
