Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1556643002: PPC: Refine "[ic] Fixed receiver_map register trashing in KeyedStoreIC megamorphic." (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Refine "[ic] Fixed receiver_map register trashing in KeyedStoreIC megamorphic." Do not abstract r0 as a general scratch register -- usage is valid only in short, localized sequences (since its value may be altered implicitly by some macro operations). R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:571370 LOG=N Committed: https://crrev.com/49e25ff4c7fb148cbbb6b4dc3fad33e180b64316 Cr-Commit-Position: refs/heads/master@{#33062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M src/ic/ppc/ic-ppc.cc View 6 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556643002/1
4 years, 11 months ago (2015-12-30 14:41:15 UTC) #2
MTBrandyberry
4 years, 11 months ago (2015-12-30 14:48:42 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-30 15:02:03 UTC) #5
JoranSiu
On 2015/12/30 15:02:03, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 11 months ago (2015-12-30 15:43:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556643002/1
4 years, 11 months ago (2015-12-30 16:08:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 16:09:37 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 16:10:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49e25ff4c7fb148cbbb6b4dc3fad33e180b64316
Cr-Commit-Position: refs/heads/master@{#33062}

Powered by Google App Engine
This is Rietveld 408576698