Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 155663002: Fixed coping printer names. (Closed)

Created:
6 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 10 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Fixed coping printer names. TBR=noamsml Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249085

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M printing/backend/print_backend_win.cc View 1 2 3 chunks +10 lines, -4 lines 1 comment Download

Messages

Total messages: 15 (0 generated)
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-05 06:49:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/155663002/20001
6 years, 10 months ago (2014-02-05 06:58:25 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-05 08:20:20 UTC) #3
commit-bot: I haz the power
Failed to trigger a try job on win_rel HTTP Error 400: Bad Request
6 years, 10 months ago (2014-02-05 08:27:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/155663002/270001
6 years, 10 months ago (2014-02-05 08:27:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 09:48:35 UTC) #6
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=45029
6 years, 10 months ago (2014-02-05 09:48:36 UTC) #7
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-05 09:55:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/155663002/270001
6 years, 10 months ago (2014-02-05 10:02:01 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 11:14:39 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=45080
6 years, 10 months ago (2014-02-05 11:14:41 UTC) #11
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 10 months ago (2014-02-05 18:27:04 UTC) #12
Noam Samuel
lgtm https://codereview.chromium.org/155663002/diff/270001/printing/backend/print_backend_win.cc File printing/backend/print_backend_win.cc (right): https://codereview.chromium.org/155663002/diff/270001/printing/backend/print_backend_win.cc#newcode62 printing/backend/print_backend_win.cc:62: DCHECK_EQ(sizeof(PaperName), sizeof(wchar_t) * kMaxPaperName); Very minor nit: This ...
6 years, 10 months ago (2014-02-05 18:37:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/155663002/270001
6 years, 10 months ago (2014-02-05 18:43:28 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 19:40:54 UTC) #15
Message was sent while issue was closed. 
Change committed as 249085

Powered by Google App Engine
This is Rietveld 408576698