components/safe_browsing_db/util.h - Issue 1556613002: Adds SB V4 response handler to Protocol Manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/util.h

Issue 1556613002: Adds SB V4 response handler to Protocol Manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@osb-pm-1

Patch Set: Review Comments Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing_db/util.h

diff --git a/components/safe_browsing_db/util.h b/components/safe_browsing_db/util.h

index dfa38e88daccf16715143353b7f923c2644c10fd..beb804ad71e14e4b07d9192691359f327604098d 100644

--- a/components/safe_browsing_db/util.h

+++ b/components/safe_browsing_db/util.h

@@ -64,6 +64,9 @@ struct SBFullHashResult {

// TODO(shess): Refactor to allow ListType here.

int list_id;

std::string metadata;

+ // Used only for V4 results. The cache lifetime for this result. The response

+ // must not be cached for more than this duration to avoid false positives.

+ base::TimeDelta cache_duration;

};

// Caches individual response from GETHASH request.