Adds SB V4 response handler to Protocol Manager.

chrome/browser/safe_browsing/protocol_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_PROTOCOL_MANAGER_H_
 #define CHROME_BROWSER_SAFE_BROWSING_PROTOCOL_MANAGER_H_
 
 // A class that implements Chrome's interface with the SafeBrowsing protocol.
 // See https://developers.google.com/safe-browsing/developers_guide_v2 for
 // protocol details.
@@ skipping 185 matching lines @@
 
  private:
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest, TestBackOffTimes);
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest, TestChunkStrings);
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest, TestGetHashUrl);
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest,
                            TestGetV4HashUrl);
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest,
                            TestGetV4HashRequest);
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest,
+                           TestParseV4HashResponse);
+  FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest,
+                           TestParseV4HashResponseWrongThreatEntryType);
+  FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest,
+                           TestParseV4HashResponseSocialEngineeringThreatType);
+  FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest,
+                           TestParseV4HashResponseNonPermissionMetadata);
+  FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest,
                            TestGetHashBackOffTimes);
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest, TestNextChunkUrl);
   FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest, TestUpdateUrl);
   friend class SafeBrowsingServerTest;
   friend class SBProtocolManagerFactoryImpl;
 
   // Internal API for fetching information from the SafeBrowsing servers. The
   // GetHash requests are higher priority since they can block user requests
   // so are handled separately.
   enum SafeBrowsingRequestType {
@@ skipping 20 matching lines @@
 
   // Generates GetHash request URL for retrieving full hashes.
   GURL GetHashUrl(bool is_extended_reporting) const;
   // Generates URL for reporting safe browsing hits for UMA users.
 
   // Generates GetHashWithApis Pver4 request URL for retrieving full hashes.
   // |request_base64| is the serialized FindFullHashesRequest protocol buffer
   // encoded in base 64.
   GURL GetV4HashUrl(const std::string& request_base64) const;
 
-  // Fills a FindFullHashesRequest protocol buffer for an API_ABUSE request.
+  // Fills a FindFullHashesRequest protocol buffer for a V4 request.
   // Returns the serialized and base 64 encoded request as a string.
   std::string GetV4HashRequest(const std::vector<SBPrefix>& prefixes,
                                ThreatType threat_type);
 
+  // Parses a FindFullHashesResponse protocol buffer and fills the results in
+  // |full_hashes| and |cache_lifetime|. |data_base64| is the base 64 encoded

[awoz, 2015/12/30 18:23:13]

Can you explain what |cache_lifetime| is? It's unclear how |cache_lifetime| and
SBFullHashResult's |cache_duration| differ.

[kcarattini, 2016/01/04 00:52:01]

Done.

+  // string of a serialized FindFullHashes procol buffer. Returns true if

[awoz, 2015/12/30 18:23:13]

s/procol/protocol

[kcarattini, 2016/01/04 00:52:01]

Done.

+  // parsing is successfull, false otherwise.

[awoz, 2015/12/30 18:23:13]

s/successfull/successful

[kcarattini, 2016/01/04 00:52:01]

Done.

+  bool ParseV4HashResponse(const std::string& data_base64,
+                           std::vector<SBFullHashResult>* full_hashes,
+                           base::TimeDelta* cache_lifetime);
+
   // Composes a ChunkUrl based on input string.
   GURL NextChunkUrl(const std::string& input) const;
 
   // Returns the time for the next update request. If |back_off| is true,
   // the time returned will increment an error count and return the appriate
   // next time (see ScheduleNextUpdate below).
   base::TimeDelta GetNextUpdateInterval(bool back_off);
 
   // Worker function for calculating GetHash and Update backoff times (in
   // seconds). |multiplier| is doubled for each consecutive error between the
@@ skipping 206 matching lines @@
       AddChunksCallback callback) = 0;
 
   // Delete chunks from the database.
   virtual void DeleteChunks(
       scoped_ptr<std::vector<SBChunkDelete> > chunk_deletes) = 0;
 };
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_PROTOCOL_MANAGER_H_