Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1556583002: Parse Physical Web UMA cache more robustly (Closed)

Created:
4 years, 11 months ago by cco3
Modified:
4 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews, mattreynolds
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse Physical Web UMA cache more robustly Instead of casting Numbers to Integer or Long (which doesn't work), we use longValue() and intValue(). BUG=529962 Committed: https://crrev.com/a3a65c4362153094ec3dfc178e8fa8e880192533 Cr-Commit-Position: refs/heads/master@{#367186}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Handled Dan's nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java View 1 2 chunks +36 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
cco3
4 years, 11 months ago (2015-12-30 00:02:57 UTC) #2
gone
lgtm https://codereview.chromium.org/1556583002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java (right): https://codereview.chromium.org/1556583002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java#newcode190 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java:190: Number[] arr = new Number[values.length()]; nit: arr -> ...
4 years, 11 months ago (2015-12-30 20:05:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556583002/20001
4 years, 11 months ago (2015-12-30 20:33:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2015-12-30 21:21:38 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 21:22:43 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a3a65c4362153094ec3dfc178e8fa8e880192533
Cr-Commit-Position: refs/heads/master@{#367186}

Powered by Google App Engine
This is Rietveld 408576698