Implement an SkPaint-based image filter

samplecode/SampleFilterFuzz.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include "SampleCode.h"
+#include "Sk1DPathEffect.h"
+#include "Sk2DPathEffect.h"
 #include "SkAlphaThresholdFilter.h"
+#include "SkArcToPathEffect.h"
+#include "SkAnnotation.h"
 #include "SkBlurImageFilter.h"
+#include "SkBlurMaskFilter.h"
 #include "SkCanvas.h"
 #include "SkColorCubeFilter.h"
 #include "SkColorFilter.h"
 #include "SkColorFilterImageFilter.h"
+#include "SkColorMatrixFilter.h"
 #include "SkComposeImageFilter.h"
+#include "SkCornerPathEffect.h"
+#include "SkDashPathEffect.h"
 #include "SkData.h"
+#include "SkDiscretePathEffect.h"
 #include "SkDisplacementMapEffect.h"
 #include "SkDropShadowImageFilter.h"
+#include "SkEmbossMaskFilter.h"
 #include "SkFlattenableSerialization.h"
 #include "SkImageSource.h"
+#include "SkLayerRasterizer.h"
 #include "SkLightingImageFilter.h"
+#include "SkLumaColorFilter.h"
 #include "SkMagnifierImageFilter.h"
 #include "SkMatrixConvolutionImageFilter.h"
 #include "SkMergeImageFilter.h"
 #include "SkMorphologyImageFilter.h"
 #include "SkOffsetImageFilter.h"
+#include "SkPaintImageFilter.h"
 #include "SkPerlinNoiseShader.h"
 #include "SkPictureImageFilter.h"
 #include "SkPictureRecorder.h"
 #include "SkPoint3.h"
 #include "SkRandom.h"
-#include "SkRectShaderImageFilter.h"
+#include "SkTableColorFilter.h"
 #include "SkTestImageFilters.h"
 #include "SkTileImageFilter.h"
+#include "SkTypeface.h"
 #include "SkView.h"
 #include "SkXfermodeImageFilter.h"
 #include <stdio.h>
 #include <time.h>
 
 //#define SK_ADD_RANDOM_BIT_FLIPS
 //#define SK_FUZZER_IS_VERBOSE
 
 static const uint32_t kSeed = (uint32_t)(time(nullptr));
 static SkRandom gRand(kSeed);
@@ skipping 43 matching lines @@
     }
 
     if (!positiveOnly && (R(4) == 1)) v = -v;
     return v;
 }
 
 static SkScalar make_scalar(bool positiveOnly = false) {
     return make_number(positiveOnly);
 }
 
+static SkString make_string() {
+    int length = R(1000);
+    SkString str(length);
+    for (int i = 0; i < length; ++i) {
+        str[i] = static_cast<char>(R(256));
+    }
+    return str;
+}
+
+static SkString make_font_name() {
+    int sel = R(8);
+
+    switch(sel) {
+        case 0: return SkString("Courier New");
+        case 1: return SkString("Helvetica");
+        case 2: return SkString("monospace");
+        case 3: return SkString("sans-serif");
+        case 4: return SkString("serif");
+        case 5: return SkString("Times");
+        case 6: return SkString("Times New Roman");
+        case 7:
+        default:
+            return make_string();
+    }
+}
+
+static bool make_bool() {
+    return R(2) == 1;
+}
+
 static SkRect make_rect() {
     return SkRect::MakeWH(SkIntToScalar(R(static_cast<float>(kBitmapSize))),
                           SkIntToScalar(R(static_cast<float>(kBitmapSize))));
 }
 
 static SkRegion make_region() {
     SkIRect iRegion = SkIRect::MakeXYWH(R(static_cast<float>(kBitmapSize)),
                                         R(static_cast<float>(kBitmapSize)),
                                         R(static_cast<float>(kBitmapSize)),
                                         R(static_cast<float>(kBitmapSize)));
     return SkRegion(iRegion);
 }
 
 static SkMatrix make_matrix() {
     SkMatrix m;
     for (int i = 0; i < 9; ++i) {
         m[i] = make_scalar();
     }
     return m;
 }
 
 static SkXfermode::Mode make_xfermode() {
     return static_cast<SkXfermode::Mode>(R(SkXfermode::kLastMode+1));
 }
 
+static SkPaint::Align make_paint_align() {
+    return static_cast<SkPaint::Align>(R(SkPaint::kRight_Align+1));
+}
+
+static SkPaint::Hinting make_paint_hinting() {
+    return static_cast<SkPaint::Hinting>(R(SkPaint::kFull_Hinting+1));
+}
+
+static SkPaint::Style make_paint_style() {
+    return static_cast<SkPaint::Style>(R(SkPaint::kStrokeAndFill_Style+1));
+}
+
+static SkPaint::Cap make_paint_cap() {
+    return static_cast<SkPaint::Cap>(R(SkPaint::kDefault_Cap+1));
+}
+
+static SkPaint::Join make_paint_join() {
+    return static_cast<SkPaint::Join>(R(SkPaint::kDefault_Join+1));
+}
+
+static SkPaint::TextEncoding make_paint_text_encoding() {
+    return static_cast<SkPaint::TextEncoding>(R(SkPaint::kGlyphID_TextEncoding+1));
+}
+
+static SkBlurStyle make_blur_style() {
+    return static_cast<SkBlurStyle>(R(kLastEnum_SkBlurStyle+1));
+}
+
+static SkBlurMaskFilter::BlurFlags make_blur_mask_filter_flag() {
+    return static_cast<SkBlurMaskFilter::BlurFlags>(R(SkBlurMaskFilter::kAll_BlurFlag+1));
+}
+
+static SkFilterQuality make_filter_quality() {
+    return static_cast<SkFilterQuality>(R(kHigh_SkFilterQuality+1));
+}
+
+static SkTypeface::Style make_typeface_style() {
+    return static_cast<SkTypeface::Style>(R(SkTypeface::kBoldItalic+1));
+}
+
+static SkPath1DPathEffect::Style make_path_1d_path_effect_style() {
+    return static_cast<SkPath1DPathEffect::Style>(R(SkPath1DPathEffect::kStyleCount));
+}
+
 static SkColor make_color() {
     return (R(2) == 1) ? 0xFFC0F0A0 : 0xFF000090;
 }
 
 static SkDropShadowImageFilter::ShadowMode make_shadow_mode() {
     return (R(2) == 1) ? SkDropShadowImageFilter::kDrawShadowAndForeground_ShadowMode :
                          SkDropShadowImageFilter::kDrawShadowOnly_ShadowMode;
 }
 
 static SkPoint3 make_point() {
@@ skipping 118 matching lines @@
 
     paint.setAntiAlias(true);
 
     paint.setColor(SK_ColorRED);
     canvas->drawCircle(SkIntToScalar(kBitmapSize/2), SkIntToScalar(kBitmapSize/2), SkIntToScalar(kBitmapSize/3), paint);
     paint.setColor(SK_ColorBLACK);
     paint.setTextSize(SkIntToScalar(kBitmapSize/3));
     canvas->drawText("Picture", 7, SkIntToScalar(kBitmapSize/2), SkIntToScalar(kBitmapSize/4), paint);
 }
 
+static void rand_color_table(uint8_t* table) {
+    for (int i = 0; i < 256; ++i) {
+        table[i] = R(256);
+    }
+}
+
+static SkColorFilter* make_color_filter() {
+    SkColorFilter* colorFilter = nullptr;
+    switch (R(6)) {
+        case 0: {
+            SkScalar array[20];
+            for (int i = 0; i < 20; ++i) {
+                array[i] = make_scalar();
+            }
+            colorFilter = SkColorMatrixFilter::Create(array);
+            break;
+        }
+        case 1:
+            colorFilter = SkLumaColorFilter::Create();
+            break;
+        case 2: {
+            uint8_t tableA[256];
+            uint8_t tableR[256];
+            uint8_t tableG[256];
+            uint8_t tableB[256];
+            rand_color_table(tableA);
+            rand_color_table(tableR);
+            rand_color_table(tableG);
+            rand_color_table(tableB);
+            colorFilter = SkTableColorFilter::CreateARGB(tableA, tableR, tableG, tableB);
+            break;
+        }
+        case 3:
+            colorFilter = SkColorFilter::CreateModeFilter(make_color(), make_xfermode());
+            break;
+        case 4:
+            colorFilter = SkColorFilter::CreateLightingFilter(make_color(), make_color());
+            break;
+        case 5:
+        default:

[Stephen White, 2016/01/08 18:20:47]

Nit: for clarity, explicitly set colorFilter = nullptr here, and don't
initialize it above?

[ajuma, 2016/01/08 19:09:08]

Done.

+        break;
+    }
+    return colorFilter;
+}
+
+static SkPath make_path() {
+    SkPath path;
+    int numOps = R(30);
+    for (int i = 0; i < numOps; ++i) {
+        if (R(2) == 1) {

[Stephen White, 2016/01/08 18:20:48]

How about cubicTo(), quadTo(), conicTo()?

[ajuma, 2016/01/08 19:09:08]

Done.

+            path.moveTo(make_scalar(), make_scalar());
+        }  else {
+            path.lineTo(make_scalar(), make_scalar());
+        }
+    }
+    path.close();
+    return path;
+}
+
+static SkPathEffect* make_path_effect(bool canBeNull = true) {
+    SkPathEffect* pathEffect = nullptr;
+    if (canBeNull && (R(3) == 1)) { return pathEffect; }
+
+    switch (R(9)) {
+        case 0:
+            pathEffect = SkArcToPathEffect::Create(make_scalar(true));
+            break;
+        case 1: {
+            SkAutoTUnref<SkPathEffect> outer(make_path_effect(false));
+            SkAutoTUnref<SkPathEffect> inner(make_path_effect(false));
+            pathEffect = SkComposePathEffect::Create(outer, inner);
+            break;
+        }
+        case 2:
+            pathEffect = SkCornerPathEffect::Create(make_scalar());
+            break;
+        case 3: {
+            int count = R(10);
+            SkScalar intervals[10];
+            for (int i = 0; i < count; ++i) {
+                intervals[i] = make_scalar();
+            }
+            pathEffect = SkDashPathEffect::Create(intervals, count, make_scalar());
+            break;
+        }
+        case 4:
+            pathEffect = SkDiscretePathEffect::Create(make_scalar(), make_scalar());
+            break;
+        case 5:
+            pathEffect = SkPath1DPathEffect::Create(make_path(),
+                                                    make_scalar(),
+                                                    make_scalar(),
+                                                    make_path_1d_path_effect_style());
+            break;
+        case 6:
+            pathEffect = SkLine2DPathEffect::Create(make_scalar(), make_matrix());
+            break;
+        case 7:
+            pathEffect = SkPath2DPathEffect::Create(make_matrix(), make_path());
+            break;
+        case 8:
+        default:
+            pathEffect = SkSumPathEffect::Create(make_path_effect(false),
+                                                 make_path_effect(false));
+            break;
+    }
+    return pathEffect;
+}
+
+static SkMaskFilter* make_mask_filter() {
+    SkMaskFilter* maskFilter = nullptr;
+    switch (R(3)) {
+        case 0:
+            maskFilter = SkBlurMaskFilter::Create(make_blur_style(),
+                                                  make_scalar(),
+                                                  make_blur_mask_filter_flag());
+        case 1: {
+            SkEmbossMaskFilter::Light light;
+            for (int i = 0; i < 3; ++i) {
+                light.fDirection[i] = make_scalar();
+            }
+            light.fPad = R(65536);
+            light.fAmbient = R(256);
+            light.fSpecular = R(256);
+            maskFilter = SkEmbossMaskFilter::Create(make_scalar(),
+                                                    light);
+        }
+        case 2:

[Stephen White, 2016/01/08 18:20:48]

Nit: set maskFilter = nullptr here explicitly, and don't initialize it above?

[ajuma, 2016/01/08 19:09:08]

Done.

+        default:
+            break;
+    }
+    return maskFilter;
+}
+
 static SkImageFilter* make_image_filter(bool canBeNull = true) {
     SkImageFilter* filter = 0;
 
     // Add a 1 in 3 chance to get a nullptr input
     if (canBeNull && (R(3) == 1)) { return filter; }
 
     enum { ALPHA_THRESHOLD, MERGE, COLOR, LUT3D, BLUR, MAGNIFIER,
            DOWN_SAMPLE, XFERMODE, OFFSET, MATRIX, MATRIX_CONVOLUTION, COMPOSE,
            DISTANT_LIGHT, POINT_LIGHT, SPOT_LIGHT, NOISE, DROP_SHADOW,
-           MORPHOLOGY, BITMAP, DISPLACE, TILE, PICTURE, NUM_FILTERS };
+           MORPHOLOGY, BITMAP, DISPLACE, TILE, PICTURE, PAINT, NUM_FILTERS };
 
     switch (R(NUM_FILTERS)) {
     case ALPHA_THRESHOLD:
         filter = SkAlphaThresholdFilter::Create(make_region(), make_scalar(), make_scalar());
         break;
     case MERGE:
         filter = SkMergeImageFilter::Create(make_image_filter(), make_image_filter(), make_xfermode());
         break;
     case COLOR:
     {
-        SkAutoTUnref<SkColorFilter> cf((R(2) == 1) ?
-                 SkColorFilter::CreateModeFilter(make_color(), make_xfermode()) :
-                 SkColorFilter::CreateLightingFilter(make_color(), make_color()));
+        SkAutoTUnref<SkColorFilter> cf(make_color_filter());
         filter = cf.get() ? SkColorFilterImageFilter::Create(cf, make_image_filter()) : 0;
     }
         break;
     case LUT3D:
     {
         int cubeDimension;
         SkAutoDataUnref lut3D(make_3Dlut(&cubeDimension, (R(2) == 1), (R(2) == 1), (R(2) == 1)));
         SkAutoTUnref<SkColorFilter> cf(SkColorCubeFilter::Create(lut3D, cubeDimension));
         filter = cf.get() ? SkColorFilterImageFilter::Create(cf, make_image_filter()) : 0;
     }
@@ skipping 72 matching lines @@
                  make_point(), make_scalar(), make_scalar(), make_color(),
                  make_scalar(), make_scalar(), SkIntToScalar(R(10)), make_image_filter());
         break;
     case NOISE:
     {
         SkAutoTUnref<SkShader> shader((R(2) == 1) ?
             SkPerlinNoiseShader::CreateFractalNoise(
                 make_scalar(true), make_scalar(true), R(10.0f), make_scalar()) :
             SkPerlinNoiseShader::CreateTurbulence(
                 make_scalar(true), make_scalar(true), R(10.0f), make_scalar()));
+        SkPaint paint;
+        paint.setShader(shader);
         SkImageFilter::CropRect cropR(SkRect::MakeWH(SkIntToScalar(kBitmapSize),
                                                      SkIntToScalar(kBitmapSize)));
-        filter = SkRectShaderImageFilter::Create(shader, &cropR);
+        filter = SkPaintImageFilter::Create(paint, &cropR);
     }
         break;
     case DROP_SHADOW:
         filter = SkDropShadowImageFilter::Create(make_scalar(), make_scalar(), make_scalar(true),
                     make_scalar(true), make_color(), make_shadow_mode(), make_image_filter(),
                     nullptr);
         break;
     case MORPHOLOGY:
         if (R(2) == 1) {
             filter = SkDilateImageFilter::Create(R(static_cast<float>(kBitmapSize)),
@@ skipping 26 matching lines @@
         SkRTreeFactory factory;
         SkPictureRecorder recorder;
         SkCanvas* recordingCanvas = recorder.beginRecording(SkIntToScalar(kBitmapSize), 
                                                             SkIntToScalar(kBitmapSize), 
                                                             &factory, 0);
         drawSomething(recordingCanvas);
         SkAutoTUnref<SkPicture> pict(recorder.endRecording());
         filter = SkPictureImageFilter::Create(pict.get(), make_rect());
     }
         break;
+    case PAINT:
+    {
+        SkPaint paint;
+        paint.setHinting(make_paint_hinting());
+        paint.setAntiAlias(make_bool());
+        paint.setDither(make_bool());
+        paint.setLinearText(make_bool());
+        paint.setSubpixelText(make_bool());
+        paint.setLCDRenderText(make_bool());
+        paint.setEmbeddedBitmapText(make_bool());
+        paint.setAutohinted(make_bool());
+        paint.setVerticalText(make_bool());
+        paint.setUnderlineText(make_bool());
+        paint.setStrikeThruText(make_bool());
+        paint.setFakeBoldText(make_bool());
+        paint.setDevKernText(make_bool());
+        paint.setFilterQuality(make_filter_quality());
+        paint.setStyle(make_paint_style());
+        paint.setColor(make_color());
+        paint.setStrokeWidth(make_scalar());
+        paint.setStrokeMiter(make_scalar());
+        paint.setStrokeCap(make_paint_cap());
+        paint.setStrokeJoin(make_paint_join());
+        paint.setColorFilter(make_color_filter());
+        paint.setXfermodeMode(make_xfermode());
+        paint.setPathEffect(make_path_effect());
+        paint.setMaskFilter(make_mask_filter());
+        SkAutoTUnref<SkTypeface> typeface(
+            SkTypeface::CreateFromName(make_font_name().c_str(), make_typeface_style()));
+        paint.setTypeface(typeface);
+        SkLayerRasterizer::Builder rasterizerBuilder;
+        SkPaint paintForRasterizer;
+        rasterizerBuilder.addLayer(paintForRasterizer);
+        SkAutoTUnref<SkRasterizer> rasterizer(rasterizerBuilder.detachRasterizer());
+        paint.setRasterizer(rasterizer);
+        paint.setImageFilter(make_image_filter());
+        SkAutoDataUnref data(make_3Dlut(nullptr, make_bool(), make_bool(), make_bool()));
+        SkAutoTUnref<SkAnnotation> annotation(
+            SkAnnotation::Create(make_string().c_str(), data));
+        paint.setAnnotation(annotation);
+        paint.setTextAlign(make_paint_align());
+        paint.setTextSize(make_scalar());
+        paint.setTextScaleX(make_scalar());
+        paint.setTextSkewX(make_scalar());
+        paint.setTextEncoding(make_paint_text_encoding());
+        SkImageFilter::CropRect cropR(make_rect());
+        filter = SkPaintImageFilter::Create(paint, &cropR);
+    }
     default:
         break;
     }
     return (filter || canBeNull) ? filter : make_image_filter(canBeNull);
 }
 
 static SkImageFilter* make_serialized_image_filter() {
     SkAutoTUnref<SkImageFilter> filter(make_image_filter(false));
     SkAutoTUnref<SkData> data(SkValidatingSerializeFlattenable(filter));
     const unsigned char* ptr = static_cast<const unsigned char*>(data->data());
@@ skipping 83 matching lines @@
     }
 
 private:
     typedef SkView INHERITED;
 };
 
 //////////////////////////////////////////////////////////////////////////////
 
 static SkView* MyFactory() { return new ImageFilterFuzzView; }
 static SkViewRegister reg(MyFactory);