Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 155653003: [Android WebView] Add AwResource.setResources() and setErrorPageResources(). (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

[Android WebView] Add AwResource.setResources() and setErrorPageResources(). This is part 1 of a two-sided patch to get rid of public static fields in AwResource.java. R=mnaganov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249505

Patch Set 1 #

Patch Set 2 : add AwShellResourceProvider.java #

Patch Set 3 : add comments to fix presubmit warnings #

Patch Set 4 : update findbugs #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwResource.java View 1 2 3 chunks +14 lines, -0 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellResourceProvider.java View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Lei Zhang
per discussion on https://codereview.chromium.org/149113003/
6 years, 10 months ago (2014-02-05 08:59:02 UTC) #1
Lei Zhang
And I forgot to change AwShellResourceProvider.java
6 years, 10 months ago (2014-02-05 09:00:11 UTC) #2
Lei Zhang
Onwards to patch set 2.
6 years, 10 months ago (2014-02-05 09:01:44 UTC) #3
mnaganov (inactive)
LGTM, thanks! I will notify you when it will be possible to land the second ...
6 years, 10 months ago (2014-02-05 09:21:09 UTC) #4
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-05 09:32:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/155653003/50001
6 years, 10 months ago (2014-02-05 09:35:58 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 10:01:26 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=48236
6 years, 10 months ago (2014-02-05 10:01:27 UTC) #8
Lei Zhang
I added some comments to make the presubmit happy.
6 years, 10 months ago (2014-02-06 00:00:09 UTC) #9
mnaganov (inactive)
Still LGTM
6 years, 10 months ago (2014-02-06 08:34:48 UTC) #10
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-06 09:02:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/155653003/220001
6 years, 10 months ago (2014-02-06 09:07:34 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 10:58:27 UTC) #13
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=147294
6 years, 10 months ago (2014-02-06 10:58:28 UTC) #14
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-06 20:51:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/155653003/580001
6 years, 10 months ago (2014-02-06 20:55:28 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 21:14:43 UTC) #17
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=48723
6 years, 10 months ago (2014-02-06 21:14:44 UTC) #18
hush (inactive)
On 2014/02/06 21:14:44, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-02-06 21:21:43 UTC) #19
Lei Zhang
Committed patchset #5 manually as r249505 (presubmit successful).
6 years, 10 months ago (2014-02-06 21:29:12 UTC) #20
boliu
6 years, 10 months ago (2014-02-06 21:43:34 UTC) #21
Message was sent while issue was closed. 
On 2014/02/06 21:21:43, hush wrote:
> On 2014/02/06 21:14:44, I haz the power (commit-bot) wrote:
> > Retried try job too often on chromium_presubmit for step(s) presubmit
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
> 
> It seems the presubmit checks failed. Can you take a look and fix it? Add a
BUG
> number for it?
> 
> ** Presubmit Messages **
> If this change has an associated bug, add BUG=[bug number].
> 
>
/mnt/scratch0/b_used/build/slave/linux/build/src/build/android/buildbot/tests/bb_run_bot_test.py
> (1.18s)
> 
> ** Presubmit Warnings **
> Following files should only contain deletions.
>   build/android/findbugs_filter/findbugs_known_bugs.txt

The problem is not missing BUG number. It's that presubmit only allows deletions
to findbugs_known_bugs.txt , not additions or modifications. Idea was that no
one will introduce anymore findbugs issues. But AwResource is a special case and
needs 3-sided patch to fix fully. So in this case, dcommit is ok, but could have
tried on android_dbg first.

Anyway, thanks Lei for fixing all the findbugs issues!

Powered by Google App Engine
This is Rietveld 408576698