Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 155653002: Add Linux SDK to GN build. (Closed)

Created:
6 years, 10 months ago by brettw
Modified:
6 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Add Linux SDK to GN build. I forgot to actually reference this config when I created it. R=thakis@chromium.org TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
Previously all sysroot compiles in Linux failed. TBR=thakis
6 years, 10 months ago (2014-02-05 06:14:16 UTC) #1
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 10 months ago (2014-02-05 06:14:20 UTC) #2
Nico
heh, lgtm
6 years, 10 months ago (2014-02-05 06:15:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/155653002/1
6 years, 10 months ago (2014-02-05 06:18:33 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 09:09:37 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 10 months ago (2014-02-05 09:09:37 UTC) #6
brettw
6 years, 10 months ago (2014-02-06 08:35:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r249301 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698