Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: components/printing/renderer/print_web_view_helper_mac.mm

Issue 1556463003: Mark printing code as basic printing and/or print preview code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/printing/renderer/print_web_view_helper_mac.mm
diff --git a/components/printing/renderer/print_web_view_helper_mac.mm b/components/printing/renderer/print_web_view_helper_mac.mm
index e682fa3296e9d0c3173b5b757136c8e6665a1858..e94f21e54a9edce843519b7f011d30f1a4d20c27 100644
--- a/components/printing/renderer/print_web_view_helper_mac.mm
+++ b/components/printing/renderer/print_web_view_helper_mac.mm
@@ -18,8 +18,7 @@
namespace printing {
-using blink::WebFrame;
-
+#if defined(ENABLE_BASIC_PRINTING)
bool PrintWebViewHelper::PrintPagesNative(blink::WebFrame* frame,
int page_count) {
const PrintMsg_PrintPages_Params& params = *print_pages_params_;
@@ -37,10 +36,11 @@ bool PrintWebViewHelper::PrintPagesNative(blink::WebFrame* frame,
}
return true;
}
+#endif // defined(ENABLE_BASIC_PRINTING)
void PrintWebViewHelper::PrintPageInternal(
const PrintMsg_PrintPage_Params& params,
- WebFrame* frame) {
+ blink::WebFrame* frame) {
PdfMetafileSkia metafile;
if (!metafile.Init())
return;
@@ -69,6 +69,7 @@ void PrintWebViewHelper::PrintPageInternal(
Send(new PrintHostMsg_DidPrintPage(routing_id(), page_params));
}
+#if defined(ENABLE_PRINT_PREVIEW)
bool PrintWebViewHelper::RenderPreviewPage(
int page_number,
const PrintMsg_Print_Params& print_params) {
@@ -109,10 +110,11 @@ bool PrintWebViewHelper::RenderPreviewPage(
}
return PreviewPageRendered(page_number, draft_metafile.get());
}
+#endif // defined(ENABLE_PRINT_PREVIEW)
void PrintWebViewHelper::RenderPage(const PrintMsg_Print_Params& params,
int page_number,
- WebFrame* frame,
+ blink::WebFrame* frame,
bool is_preview,
PdfMetafileSkia* metafile,
gfx::Size* page_size,

Powered by Google App Engine
This is Rietveld 408576698