Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2484)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 1556463003: Mark printing code as basic printing and/or print preview code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | chrome/browser/ui/libgtk2ui/gtk2_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index 101094aa790ceb2c818ad423a4ec32a0b057d237..efaa96a83b148475144cece67fb5ef52641a5848 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -1629,8 +1629,6 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
return;
command_executed_ = true;
- RenderFrameHost* render_frame_host = GetRenderFrameHost();
-
// Process extension menu items.
if (ContextMenuMatcher::IsExtensionsCustomCommandId(id)) {
extension_items_.ExecuteCommand(id, source_web_contents_, params_);
@@ -1896,6 +1894,7 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
case IDC_PRINT: {
#if defined(ENABLE_PRINTING)
if (params_.media_type != WebContextMenuData::MediaTypeNone) {
+ RenderFrameHost* render_frame_host = GetRenderFrameHost();
if (render_frame_host) {
render_frame_host->Send(new PrintMsg_PrintNodeUnderContextMenu(
render_frame_host->GetRoutingID()));
@@ -1907,7 +1906,7 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
source_web_contents_,
GetPrefs(browser_context_)->GetBoolean(prefs::kPrintPreviewDisabled),
!params_.selection_text.empty());
-#endif // ENABLE_PRINTING
+#endif // defined(ENABLE_PRINTING)
break;
}
« no previous file with comments | « build/all.gyp ('k') | chrome/browser/ui/libgtk2ui/gtk2_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698