Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

Issue 1556463003: Mark printing code as basic printing and/or print preview code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_handler.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
index 5af74615cd43c589b70dd0a8a8a2f518871f9b13..aa761e63b3446261c47d01e9050a673782492138 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
@@ -291,7 +291,6 @@ void ReportPrintSettingsStats(const base::DictionaryValue& settings) {
&distill_page) && distill_page) {
ReportPrintSettingHistogram(DISTILL_PAGE);
}
-
}
// Callback that stores a PDF file on disk.
@@ -1004,6 +1003,7 @@ void PrintPreviewHandler::HandlePrint(const base::ListValue* args) {
ReportUserActionHistogram(PRINT_WITH_CLOUD_PRINT);
SendCloudPrintJob(data.get());
} else {
+#if defined(ENABLE_BASIC_PRINTING)
Vitaly Buka (NO REVIEWS) 2016/01/04 21:36:49 As I remember basic printing is system dialog prin
Lei Zhang 2016/01/07 03:01:09 We have: no printing - embedded platforms? enable_
Vitaly Buka (NO REVIEWS) 2016/01/07 04:19:35 It was possible to build on Windows (don't remembe
Vitaly Buka (NO REVIEWS) 2016/01/07 04:21:14 Sorry, I tried to say: it was possible to build "w
Lei Zhang 2016/01/07 04:47:50 With this CL, all the configurations are buildable
Vitaly Buka (NO REVIEWS) 2016/01/07 23:50:23 Then I am fine with that too :-)
bool system_dialog = false;
settings->GetBoolean(printing::kSettingShowSystemDialog, &system_dialog);
if (system_dialog) {
@@ -1054,6 +1054,9 @@ void PrintPreviewHandler::HandlePrint(const base::ListValue* args) {
printing::PrintViewManager::FromWebContents(initiator);
print_view_manager->PrintPreviewDone();
}
+#else
+ NOTREACHED();
+#endif // defined(ENABLE_BASIC_PRINTING)
}
}
« no previous file with comments | « chrome/browser/ui/webui/print_preview/print_preview_handler.h ('k') | chrome/renderer/chrome_render_frame_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698