Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1556463002: Fix bootstraps_deps of tools/perf to include build/android/pylib/. (Closed)

Created:
4 years, 11 months ago by nednguyen
Modified:
4 years, 11 months ago
Reviewers:
llozano
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bootstraps_deps of tools/perf to include build/android/pylib/. After John's work in crbug.com/560559, telemetry project no longer depends on pylib, hence tools/perf which is a user of telemetry must specify this deps explictly. BUG=572700, 560559 TBR=jbudorick@chromium.org Committed: https://crrev.com/89fe15bf1183cd781a6d27983e7ce792f4641e88 Cr-Commit-Position: refs/heads/master@{#367045}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/perf/bootstrap_deps View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
nednguyen
4 years, 11 months ago (2015-12-29 02:02:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556463002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556463002/2
4 years, 11 months ago (2015-12-29 02:03:31 UTC) #6
llozano
lgtm
4 years, 11 months ago (2015-12-29 02:03:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:2)
4 years, 11 months ago (2015-12-29 03:12:05 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/89fe15bf1183cd781a6d27983e7ce792f4641e88 Cr-Commit-Position: refs/heads/master@{#367045}
4 years, 11 months ago (2015-12-29 03:13:15 UTC) #11
fmeawad
4 years, 11 months ago (2015-12-29 19:06:03 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:2) has been created in
https://codereview.chromium.org/1557473002/ by fmeawad@chromium.org.

The reason for reverting is: Speculative revert:
Failed power benchmarks on N5

See https://code.google.com/p/chromium/issues/detail?id=572954 for details.

BUG=572954

.

Powered by Google App Engine
This is Rietveld 408576698