Avoid empty nearby URL list after onboarding by permitting unresolved URLs

Avoid empty nearby URL list after onboarding by permitting unresolved URLs

We currently resolve nearby URLs twice, once before showing a "nearby web
pages found" notification and once just before displaying the list of
nearby URLs. If a URL was not resolvable for the notification we avoid
re-resolving it for display. This prevents costly delays at display time
as we are only requesting data expected to already be cached by the
resolution service.

During onboarding (ie, before the user has explicitly opted into the
physical web feature) we still scan for nearby URLs but do not resolve
them for privacy reasons. This causes all URLs to be considered
"unresolvable" immediately after opting in as none have been sent to the
resolution service yet.

To fix, at display time allow ListUrlsActivity to receive the full
list of nearby URLs (including unresolved) only if the resolved list is
empty.

BUG=529962
Committed: https://crrev.com/dfbf6469013b3c6a94ae6818b87d3ef50ab58b34
Cr-Commit-Position: refs/heads/master@{#367041}

[mattreynolds, 2015-12-29 01:51:18]

mattreynolds@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[mattreynolds, 2015-12-29 01:51:18]

Hi dfalcantara, PTAL

It's a one-line bugfix for a corner case in the onboarding flow. This was
intended to be included in the previous CL but somehow got overlooked.

Thanks!

[gone, 2015-12-29 01:53:25]

lgtm

[mattreynolds, 2015-12-29 02:03:18]

The CQ bit was checked by mattreynolds@chromium.org

[commit-bot: I haz the power, 2015-12-29 02:03:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1556453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1556453002/1

[commit-bot: I haz the power, 2015-12-29 02:42:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-29 02:43:14]

Description was changed from

==========
Avoid empty nearby URL list after onboarding by permitting unresolved URLs

We currently resolve nearby URLs twice, once before showing a "nearby web
pages found" notification and once just before displaying the list of
nearby URLs. If a URL was not resolvable for the notification we avoid
re-resolving it for display. This prevents costly delays at display time
as we are only requesting data expected to already be cached by the
resolution service.

During onboarding (ie, before the user has explicitly opted into the
physical web feature) we still scan for nearby URLs but do not resolve
them for privacy reasons. This causes all URLs to be considered
"unresolvable" immediately after opting in as none have been sent to the
resolution service yet.

To fix, at display time allow ListUrlsActivity to receive the full
list of nearby URLs (including unresolved) only if the resolved list is
empty.

BUG=529962
==========

to

==========
Avoid empty nearby URL list after onboarding by permitting unresolved URLs

We currently resolve nearby URLs twice, once before showing a "nearby web
pages found" notification and once just before displaying the list of
nearby URLs. If a URL was not resolvable for the notification we avoid
re-resolving it for display. This prevents costly delays at display time
as we are only requesting data expected to already be cached by the
resolution service.

During onboarding (ie, before the user has explicitly opted into the
physical web feature) we still scan for nearby URLs but do not resolve
them for privacy reasons. This causes all URLs to be considered
"unresolvable" immediately after opting in as none have been sent to the
resolution service yet.

To fix, at display time allow ListUrlsActivity to receive the full
list of nearby URLs (including unresolved) only if the resolved list is
empty.

BUG=529962

Committed: https://crrev.com/dfbf6469013b3c6a94ae6818b87d3ef50ab58b34
Cr-Commit-Position: refs/heads/master@{#367041}
==========

[commit-bot: I haz the power, 2015-12-29 02:43:15]

Patchset 1 (id:??) landed as
https://crrev.com/dfbf6469013b3c6a94ae6818b87d3ef50ab58b34
Cr-Commit-Position: refs/heads/master@{#367041}