Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1556423002: Merge to XFA: Exit infinite loops for cross reference loading (Closed)

Created:
4 years, 11 months ago by Wei Li
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Exit infinite loops for cross reference loading When cross reference sections form a loop, our code will enter an infinite loop. Add detection and exit code for v4 cross reference loading. V5 loading was done previously. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1558093002 . (cherry picked from commit aab8f462ea3368ed4825172231131e1a10db978d) Committed: https://pdfium.googlesource.com/pdfium/+/c009e8e6bfefa4f77bc02ac0b359b9fe58af384f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -19 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 2 chunks +23 lines, -19 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
A testing/resources/bug_xrefv4_loop.pdf View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Wei Li
clean merge, TBR
4 years, 11 months ago (2016-01-05 20:49:56 UTC) #1
Wei Li
Committed patchset #1 (id:1) manually as c009e8e6bfefa4f77bc02ac0b359b9fe58af384f (presubmit successful).
4 years, 11 months ago (2016-01-05 20:51:37 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-05 22:10:11 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698