Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 15564002: Make sure we register extensions only once. Removed unused member variable. (Closed)

Created:
7 years, 7 months ago by Sven Panne
Modified:
7 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make sure we register extensions only once. Removed unused member variable. V8::Initialize() can be called from various threads simultaneously, so everything should be done only once per process or within the Isolate. For registering extensions, we do the former now. R=dslomov@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/v8.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 7 months ago (2013-05-21 11:54:34 UTC) #1
Dmitry Lomov (no reviews)
lgtm
7 years, 7 months ago (2013-05-21 11:59:37 UTC) #2
Sven Panne
7 years, 7 months ago (2013-05-21 12:03:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14730 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698