Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1556373002: Turn on shutdown (Closed)

Created:
4 years, 11 months ago by zra
Modified:
4 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/bin/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
All tests are passing for me locally on Linux and Windows with shutdown on. Let's ...
4 years, 11 months ago (2016-01-05 15:59:14 UTC) #2
siva
STV
4 years, 11 months ago (2016-01-05 18:04:28 UTC) #3
siva
lgtm
4 years, 11 months ago (2016-01-05 18:05:16 UTC) #4
zra
4 years, 11 months ago (2016-01-05 18:17:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
810a9fca13363337059460a4ebb2bae23edb5983 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698