Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 11 months ago by robertn Modified:
4 years, 11 months ago Reviewers:
ajuma, weiliangc CC:
chromium-reviews, cc-bugs_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse the correct variable in the DCHECK
A patch changed how a value was retrieved to use a different variable,
but the DCHECK was not updated to do the same. The change was
introduced in the following CL:
https://codereview.chromium.org/1479883002
TEST=Load youtube.com/tv, start a video and switch to a suggested video.
The above steps will trigger the dcheck in content_shell.
R=ajuma@chromium.org
BUG=560275
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/ce99907d561175726ac33f7b6339db3285abd546
Cr-Commit-Position: refs/heads/master@{#367527}
Patch Set 1 #
Created: 4 years, 11 months ago
Messages
Total messages: 12 (7 generated)
Description was changed from ========== Use the correct variable in the DCHECK A patch changed how a value was retrieved to use a different variable, but the DCHECK was not updated to do the same. The change was introduced in the following CL: https://codereview.chromium.org/1479883002 TEST=Load youtube.com/tv, start a video and switch to a suggested video. The above steps will trigger the dcheck in content_shell. R=ajuma@chromium.org BUG= ========== to ========== Use the correct variable in the DCHECK A patch changed how a value was retrieved to use a different variable, but the DCHECK was not updated to do the same. The change was introduced in the following CL: https://codereview.chromium.org/1479883002 TEST=Load youtube.com/tv, start a video and switch to a suggested video. The above steps will trigger the dcheck in content_shell. R=ajuma@chromium.org BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== Use the correct variable in the DCHECK A patch changed how a value was retrieved to use a different variable, but the DCHECK was not updated to do the same. The change was introduced in the following CL: https://codereview.chromium.org/1479883002 TEST=Load youtube.com/tv, start a video and switch to a suggested video. The above steps will trigger the dcheck in content_shell. R=ajuma@chromium.org BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Use the correct variable in the DCHECK A patch changed how a value was retrieved to use a different variable, but the DCHECK was not updated to do the same. The change was introduced in the following CL: https://codereview.chromium.org/1479883002 TEST=Load youtube.com/tv, start a video and switch to a suggested video. The above steps will trigger the dcheck in content_shell. R=ajuma@chromium.org BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
robertn@opera.com changed reviewers: + weiliangc@chromium.org
Description was changed from ========== Use the correct variable in the DCHECK A patch changed how a value was retrieved to use a different variable, but the DCHECK was not updated to do the same. The change was introduced in the following CL: https://codereview.chromium.org/1479883002 TEST=Load youtube.com/tv, start a video and switch to a suggested video. The above steps will trigger the dcheck in content_shell. R=ajuma@chromium.org BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Use the correct variable in the DCHECK A patch changed how a value was retrieved to use a different variable, but the DCHECK was not updated to do the same. The change was introduced in the following CL: https://codereview.chromium.org/1479883002 TEST=Load youtube.com/tv, start a video and switch to a suggested video. The above steps will trigger the dcheck in content_shell. R=ajuma@chromium.org BUG=560275 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Thanks, lgtm.
The CQ bit was checked by ajuma@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556333003/1
Message was sent while issue was closed.
Description was changed from ========== Use the correct variable in the DCHECK A patch changed how a value was retrieved to use a different variable, but the DCHECK was not updated to do the same. The change was introduced in the following CL: https://codereview.chromium.org/1479883002 TEST=Load youtube.com/tv, start a video and switch to a suggested video. The above steps will trigger the dcheck in content_shell. R=ajuma@chromium.org BUG=560275 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Use the correct variable in the DCHECK A patch changed how a value was retrieved to use a different variable, but the DCHECK was not updated to do the same. The change was introduced in the following CL: https://codereview.chromium.org/1479883002 TEST=Load youtube.com/tv, start a video and switch to a suggested video. The above steps will trigger the dcheck in content_shell. R=ajuma@chromium.org BUG=560275 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use the correct variable in the DCHECK A patch changed how a value was retrieved to use a different variable, but the DCHECK was not updated to do the same. The change was introduced in the following CL: https://codereview.chromium.org/1479883002 TEST=Load youtube.com/tv, start a video and switch to a suggested video. The above steps will trigger the dcheck in content_shell. R=ajuma@chromium.org BUG=560275 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Use the correct variable in the DCHECK A patch changed how a value was retrieved to use a different variable, but the DCHECK was not updated to do the same. The change was introduced in the following CL: https://codereview.chromium.org/1479883002 TEST=Load youtube.com/tv, start a video and switch to a suggested video. The above steps will trigger the dcheck in content_shell. R=ajuma@chromium.org BUG=560275 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ce99907d561175726ac33f7b6339db3285abd546 Cr-Commit-Position: refs/heads/master@{#367527} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ce99907d561175726ac33f7b6339db3285abd546 Cr-Commit-Position: refs/heads/master@{#367527} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
