Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 1556333003: Use the correct variable in the DCHECK (Closed)

Created:
4 years, 11 months ago by robertn
Modified:
4 years, 11 months ago
Reviewers:
ajuma, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the correct variable in the DCHECK A patch changed how a value was retrieved to use a different variable, but the DCHECK was not updated to do the same. The change was introduced in the following CL: https://codereview.chromium.org/1479883002 TEST=Load youtube.com/tv, start a video and switch to a suggested video. The above steps will trigger the dcheck in content_shell. R=ajuma@chromium.org BUG=560275 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ce99907d561175726ac33f7b6339db3285abd546 Cr-Commit-Position: refs/heads/master@{#367527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/layers/render_surface_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
robertn
4 years, 11 months ago (2016-01-05 11:16:52 UTC) #1
ajuma
Thanks, lgtm.
4 years, 11 months ago (2016-01-05 14:08:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556333003/1
4 years, 11 months ago (2016-01-05 14:08:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 15:06:21 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 15:07:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce99907d561175726ac33f7b6339db3285abd546
Cr-Commit-Position: refs/heads/master@{#367527}

Powered by Google App Engine
This is Rietveld 408576698