[runtime] Migrate several Date builtins to C++.

[runtime] Migrate several Date builtins to C++.

Almost all of the Date builtins always call into C++ at least once
anyway, so parsing, compiling and executing the JavaScript wrappers
is just a waste of time.  The most important part here is the Date
constructor itself, which is one of the blockers for new.target in
TurboFan, because compiling the Date constructor takes too much time
with TurboFan (for no reason since we end up in C++ anway).

R=cbruni@chromium.org

Committed: https://crrev.com/065e9c536f14b3d7cb4d140c6f74e024e31ee1a2
Cr-Commit-Position: refs/heads/master@{#33109}

[Benedikt Meurer, 2016-01-05 09:30:49]

Hey Camillo,

Another builtins cleanup.
Please take a look.

Thanks,
Benedikt

[Camillo Bruni, 2016-01-05 10:27:00]

LGTM with nits

https://codereview.chromium.org/1556333002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1556333002/diff/1/src/builtins.cc#newcode2132
src/builtins.cc:2132: double tv;
I'd prefer having time_value where (even though the spec uses the brilliant
"tv")

https://codereview.chromium.org/1556333002/diff/1/src/builtins.cc#newcode2286
src/builtins.cc:2286: return
*isolate->factory()->NewNumber(TimeClip(MakeDate(day, time)));
Could you combine this part with the parsing step from line 2251 on?

https://codereview.chromium.org/1556333002/diff/1/src/builtins.cc#newcode2295
src/builtins.cc:2295: if (std::isnan(tv)) {
shouldn't +/-INF also be covered here? AFAIK std:isnan won't return true for
INF.

https://codereview.chromium.org/1556333002/diff/1/src/date.h
File src/date.h (right):

https://codereview.chromium.org/1556333002/diff/1/src/date.h#newcode194
src/date.h:194: void BreakDown(int64_t time_ms, int* year, int* month, int* day,
int* weekday,
BreakDownTime might be a bit more obivous.

[Benedikt Meurer, 2016-01-05 10:30:59]

https://codereview.chromium.org/1556333002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1556333002/diff/1/src/builtins.cc#newcode2132
src/builtins.cc:2132: double tv;
On 2016/01/05 10:26:59, cbruni wrote:
> I'd prefer having time_value where (even though the spec uses the brilliant
> "tv")

Done.

https://codereview.chromium.org/1556333002/diff/1/src/builtins.cc#newcode2295
src/builtins.cc:2295: if (std::isnan(tv)) {
JSDate values can only be NaN or in the valid date range.

https://codereview.chromium.org/1556333002/diff/1/src/date.h
File src/date.h (right):

https://codereview.chromium.org/1556333002/diff/1/src/date.h#newcode194
src/date.h:194: void BreakDown(int64_t time_ms, int* year, int* month, int* day,
int* weekday,
On 2016/01/05 10:26:59, cbruni wrote:
> BreakDownTime might be a bit more obivous.

Done.

[Benedikt Meurer, 2016-01-05 10:31:05]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-01-05 10:31:06]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1556333002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-01-05 10:31:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1556333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1556333002/20001

[commit-bot: I haz the power, 2016-01-05 11:05:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-05 11:05:56]

Description was changed from

==========
[runtime] Migrate several Date builtins to C++.

Almost all of the Date builtins always call into C++ at least once
anyway, so parsing, compiling and executing the JavaScript wrappers
is just a waste of time.  The most important part here is the Date
constructor itself, which is one of the blockers for new.target in
TurboFan, because compiling the Date constructor takes too much time
with TurboFan (for no reason since we end up in C++ anway).

R=cbruni@chromium.org
==========

to

==========
[runtime] Migrate several Date builtins to C++.

Almost all of the Date builtins always call into C++ at least once
anyway, so parsing, compiling and executing the JavaScript wrappers
is just a waste of time.  The most important part here is the Date
constructor itself, which is one of the blockers for new.target in
TurboFan, because compiling the Date constructor takes too much time
with TurboFan (for no reason since we end up in C++ anway).

R=cbruni@chromium.org

Committed: https://crrev.com/065e9c536f14b3d7cb4d140c6f74e024e31ee1a2
Cr-Commit-Position: refs/heads/master@{#33109}
==========

[commit-bot: I haz the power, 2016-01-05 11:05:57]

Patchset 2 (id:??) landed as
https://crrev.com/065e9c536f14b3d7cb4d140c6f74e024e31ee1a2
Cr-Commit-Position: refs/heads/master@{#33109}