Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: net/disk_cache/simple/simple_synchronous_entry.h

Issue 15563005: **STILLBAKING** Switch SimpleCache to SequencedWorkerPool. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/simple/simple_synchronous_entry.h
diff --git a/net/disk_cache/simple/simple_synchronous_entry.h b/net/disk_cache/simple/simple_synchronous_entry.h
index fb1cc0ee1b6ac52deeac18fa7e2c6f64dff58c3c..7eb9594ab4ff3bbc2ae80aa7fdf87bd5d4453dd5 100644
--- a/net/disk_cache/simple/simple_synchronous_entry.h
+++ b/net/disk_cache/simple/simple_synchronous_entry.h
@@ -36,18 +36,23 @@ class SimpleSynchronousEntry {
uint32 data_crc32;
};
- static void OpenEntry(
+ SimpleSynchronousEntry(
+ const base::FilePath& path,
+ const std::string& key,
+ uint64 entry_hash);
+
+ ~SimpleSynchronousEntry();
+
+ void OpenEntry(
const base::FilePath& path,
const std::string& key,
uint64 entry_hash,
- SimpleSynchronousEntry** out_entry,
int* out_result);
- static void CreateEntry(
+ void CreateEntry(
const base::FilePath& path,
const std::string& key,
uint64 entry_hash,
- SimpleSynchronousEntry** out_entry,
int* out_result);
// Deletes an entry without first Opening it. Does not check if there is
@@ -95,15 +100,6 @@ class SimpleSynchronousEntry {
int64 GetFileSize() const;
private:
- SimpleSynchronousEntry(
- const base::FilePath& path,
- const std::string& key,
- uint64 entry_hash);
-
- // Like Entry, the SimpleSynchronousEntry self releases when Close() is
- // called.
- ~SimpleSynchronousEntry();
-
bool OpenOrCreateFiles(bool create);
void CloseFiles();

Powered by Google App Engine
This is Rietveld 408576698