tools/testing/dart/test_suite.dart - Issue 15563002: Correctly set the timeout of tests when using selenium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_suite.dart

Issue 15563002: Correctly set the timeout of tests when using selenium (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_suite.dart

diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart

index bd0ddbd3790bdb07c51948331ff964488f75231b..329d087b80feb417a6ca9765182c4295a9c1a166 100644

--- a/tools/testing/dart/test_suite.dart

+++ b/tools/testing/dart/test_suite.dart

@@ -998,7 +998,8 @@ class StandardTestSuite extends TestSuite {

args = [

dartDir.append('tools/testing/run_selenium.py').toNativePath(),

'--browser=$runtime',

- '--timeout=${configuration["timeout"]~/2}',

+ // NOTE: This value will be overridden by the test runner

+ '--timeout=${configuration['timeout']}',

'--out=$fullHtmlPath'];

if (runtime == 'dartium') {

args.add('--executable=$dartiumFilename');

« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »