Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1556263002: Revert of df generation: single allocation with calloc (Closed)

Created:
4 years, 11 months ago by mtklein
Modified:
4 years, 11 months ago
Reviewers:
jvanverth1, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of df generation: single allocation with calloc (patchset #2 id:20001 of https://codereview.chromium.org/1544983004/ ) Reason for revert: Crashing multiple bots, e.g. https://uberchromegw.corp.google.com/i/client.skia.android/builders/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release/builds/3525 Original issue's description: > df generation: single allocation with calloc > > The dfStorage DFData allocation can never fit in its stack space: 5px padding on each side always implies at least a 10x10 DFData allocation, but the stack space only fits 64 DFData. > > So we've always been spilling to the heap. > > If we're going to spill to the heap, we might as well allocate/free all our temporary memory in one block, and since we want it zeroed, might as well calloc. > > So in practice this replaces 1-2 malloc, 1-2 free, and 2 bzeros with 1 calloc and 1 free. > > > BUG=skia:4729 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1544983004 > > Committed: https://skia.googlesource.com/skia/+/12204d90337656542a42fa0fcccb7bec13af0cce TBR=jvanverth@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4729 Committed: https://skia.googlesource.com/skia/+/c4a0d73e9aebcb7d291aa3eb8d5b6926d9a0b77e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/core/SkDistanceFieldGen.cpp View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of df generation: single allocation with calloc
4 years, 11 months ago (2016-01-05 03:02:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556263002/1
4 years, 11 months ago (2016-01-05 03:02:35 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 03:02:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c4a0d73e9aebcb7d291aa3eb8d5b6926d9a0b77e

Powered by Google App Engine
This is Rietveld 408576698