Issue 155626: Enable isolated worlds for content scripts....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155626: Enable isolated worlds for content scripts.... (Closed)

Created:
11 years, 5 months ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Enable isolated worlds for content scripts. R=aa TEST=LayoutTests/http/tests/security/isolatedWorld/ (will be landing soon after this patch) BUG=12218 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20883

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -12 lines)			Patch
M	base/base_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base_switches.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/user_script_slave.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
M	webkit/api/public/WebFrame.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	webkit/glue/webframe.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	webkit/glue/webframe_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webframe_impl.cc	View		1 chunk	+15 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

11 years, 5 months ago (2009-07-16 18:27:14 UTC) #2

LGTM, assuming tests all pass and some sanity tests involving installing
extensions seem to work.

http://codereview.chromium.org/155626/diff/1020/45
File chrome/renderer/user_script_slave.cc (right):

http://codereview.chromium.org/155626/diff/1020/45#newcode163
Line 163: frame->ExecuteScriptInNewWorld(&sources.front(), sources.size());
Whee! I'm on the edge of my seat :)

Expand Messages | Collapse Messages