Issue 155625: A build fix for GCC 4.3....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155625: A build fix for GCC 4.3.... (Closed)

Created:
11 years, 5 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A build fix for GCC 4.3. This change just creates a wrapper function for fwrite() and check return values for it to avoid warnings of gcc 4.3. BUG=none TEST=build Chromium with GCC 4.3

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	chrome/browser/privacy_blacklist/blacklist_store.cc	View		1 chunk	+10 lines, -4 lines	1 comment	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 5 months ago (2009-07-17 17:15:49 UTC) #1

LGTM (fta wants this for the ubuntu build)

http://codereview.chromium.org/155625/diff/1/2
File chrome/browser/privacy_blacklist/blacklist_store.cc (right):

http://codereview.chromium.org/155625/diff/1/2#newcode19
Line 19: return;
Should this LOG(WARNING) ?

Expand Messages | Collapse Messages