MIPS: new style of property/function callbacks

MIPS: new style of property/function callbacks

Port r14725 (d393d88)

BUG=

[Paul Lind, 2013-05-21 16:46:39]

https://codereview.chromium.org/15562007/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/15562007/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.cc:3995: // derefernce returned value
nit: Please fix spelling and start with Capital, and end with period.
// Dereference returned value.

https://codereview.chromium.org/15562007/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.cc:4001: // load value from ReturnValue
nits again:
// Load value from ReturnValue.

https://codereview.chromium.org/15562007/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.cc:4034: //  stop("check 3");
This looks wrong. Was this a leftover from some debugging?
Please remove, unless there is some reason we need to keep this.

[kilvadyb, 2013-05-21 17:19:01]

On 2013/05/21 16:46:39, Paul Lind wrote:
>
https://codereview.chromium.org/15562007/diff/1/src/mips/macro-assembler-mips.cc

Nits are fixed, hopefully. Thanks for noticing them.

[kilvadyb, 2013-05-21 17:21:30]

https://codereview.chromium.org/15562007/diff/1/src/mips/macro-assembler-mips.cc
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/15562007/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.cc:3995: // derefernce returned value
On 2013/05/21 16:46:39, Paul Lind wrote:
> nit: Please fix spelling and start with Capital, and end with period.
> // Dereference returned value.

Done.

https://codereview.chromium.org/15562007/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.cc:4001: // load value from ReturnValue
On 2013/05/21 16:46:39, Paul Lind wrote:
> nits again:
> // Load value from ReturnValue.

Done.

https://codereview.chromium.org/15562007/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.cc:4034: //  stop("check 3");
On 2013/05/21 16:46:39, Paul Lind wrote:
> This looks wrong. Was this a leftover from some debugging?
> Please remove, unless there is some reason we need to keep this.

Done.

[Paul Lind, 2013-05-21 17:24:50]

https://codereview.chromium.org/15562007/diff/4001/src/mips/macro-assembler-m...
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/15562007/diff/4001/src/mips/macro-assembler-m...
src/mips/macro-assembler-mips.cc:3995: // Derefernce returned value.
nit: the word Derefernce is still spelled wrong. The correct spelling is
Dereference

[kilvadyb, 2013-05-21 17:47:49]

https://codereview.chromium.org/15562007/diff/4001/src/mips/macro-assembler-m...
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/15562007/diff/4001/src/mips/macro-assembler-m...
src/mips/macro-assembler-mips.cc:3995: // Derefernce returned value.
On 2013/05/21 17:24:50, Paul Lind wrote:
> nit: the word Derefernce is still spelled wrong. The correct spelling is
> Dereference

Done.

[kilvadyb, 2013-05-21 18:02:40]

On 2013/05/21 17:24:50, Paul Lind wrote:
> src/mips/macro-assembler-mips.cc:3995: // Derefernce returned value.
> nit: the word Derefernce is still spelled wrong. The correct spelling is
> Dereference

Fixed, hopefully.

[Paul Lind, 2013-05-21 18:08:15]

LGTM, thanks Balázs!

[palfia, 2013-05-21 21:11:02]

Committed as r14736.