Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1556193002: Replace spammy log message in dscache with comment. (Closed)

Created:
4 years, 11 months ago by iannucci
Modified:
4 years, 11 months ago
Reviewers:
dnj, Vadim Sh., estaab, martiniss
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Replace spammy log message in dscache with comment. Fixes luci/gae#35. R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org BUG=https://github.com/luci/gae/issues/35 Committed: https://github.com/luci/gae/commit/029cd6f3934f946171108de395774d80d2bad40d

Patch Set 1 #

Patch Set 2 : fix comment more #

Total comments: 4

Patch Set 3 : lol #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M filter/dscache/ds.go View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
iannucci
4 years, 11 months ago (2016-01-05 00:11:54 UTC) #1
martiniss
lgtm % typos https://codereview.chromium.org/1556193002/diff/20001/filter/dscache/ds.go File filter/dscache/ds.go (right): https://codereview.chromium.org/1556193002/diff/20001/filter/dscache/ds.go#newcode43 filter/dscache/ds.go:43: // Ignore this error. Either we ...
4 years, 11 months ago (2016-01-05 00:17:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556193002/40001
4 years, 11 months ago (2016-01-05 02:05:09 UTC) #5
iannucci
lol https://chromiumcodereview.appspot.com/1556193002/diff/20001/filter/dscache/ds.go File filter/dscache/ds.go (right): https://chromiumcodereview.appspot.com/1556193002/diff/20001/filter/dscache/ds.go#newcode43 filter/dscache/ds.go:43: // Ignore this error. Either we couldn't add ...
4 years, 11 months ago (2016-01-05 02:05:22 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 02:07:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/029cd6f3934f946171108de395774d80d2bad40d

Powered by Google App Engine
This is Rietveld 408576698