Use different inlining parameters for precompilation.

Use different inlining parameters for precompilation.

 - Don't consider hotness in inlining decisions as there is no counter
feedback. By itself this change would increase precompiled snapshot size by
~20%.
 - Lower size threshold for always-inline.
 - Lower size threshold for never-inline.
 - Lower max inlining depth.

dart2js ARM precompiled snapshot: 23847465 => 25436213 (+6.67%)
--noopt benchmarks: geom mean +5.61% (ARM Cortex A53)

BUG=http://dartbug.com/25097
R=fschneider@google.com, srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/899046e4fc88aeb57db68c660e46026c4931bc30

[rmacnak, 2016-01-05 00:22:57]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, srdjan@google.com

[rmacnak, 2016-01-05 00:22:58]

DeltaBlue(RunTime): 95361.47619047618 us.
DeltaBlueClosures(RunTime): 87846.65217391305 us.
Richards(RunTime): 48519.30952380953 us.
FluidMotion(RunTime): 85338899.0 us.
Tracer(RunTime): 299197.1428571429 us.
StarryStrings(RunTime): 4554948.0 us.
ParticleSystemUpdate(RunTime): 2463000.0 us.
ParticleSystemPaint(RunTime): 202600.0 us.
CompileOnceHelloHtml(RunTime): 20157.0 us.

 ==>

DeltaBlue(RunTime): 88318.13043478261 us.
DeltaBlueClosures(RunTime): 82984.16 us.
Richards(RunTime): 48020.78571428571 us.
FluidMotion(RunTime): 86716597.0 us.
Tracer(RunTime): 291059.7142857143 us.
StarryStrings(RunTime): 4358939.0 us.
ParticleSystemUpdate(RunTime): 2432000.0 us.
ParticleSystemPaint(RunTime): 172333.33333333334 us.
CompileOnceHelloHtml(RunTime): 17918.0 us.

[srdjan, 2016-01-05 00:29:11]

lgtm

[Florian Schneider, 2016-01-05 10:01:07]

lgtm

https://codereview.chromium.org/1556173002/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1556173002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:132: FLAG_inlining_size_threshold = 5;
Maybe also scale down FLAG_inlining_constant_arguments_max_size_threshold and
FLAG_inlining_constant_arguments_min_size_threshold accordingly?

[rmacnak, 2016-01-05 23:50:21]

https://codereview.chromium.org/1556173002/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1556173002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:132: FLAG_inlining_size_threshold = 5;
On 2016/01/05 10:01:07, Florian Schneider wrote:
> Maybe also scale down FLAG_inlining_constant_arguments_max_size_threshold and
> FLAG_inlining_constant_arguments_min_size_threshold accordingly?

I'll look at those in a separate CL.

[rmacnak, 2016-01-06 00:25:25]

Description was changed from

==========
Use different inlining parameters for precompilation.

 - Don't consider hotness in inlining decisions as there is no counter
feedback. By itself this change would increase precompiled snapshot size by
~20%.
 - Lower size threshold for always-inline.
 - Lower size threshold for never-inline.
 - Lower max inlining depth.

dart2js ARM precompiled snapshot: 23847465 => 25436213 (+6.67%)
--noopt benchmarks: geom mean +5.61% (ARM Cortex A53)

BUG=http://dartbug.com/25097
==========

to

==========
Use different inlining parameters for precompilation.

 - Don't consider hotness in inlining decisions as there is no counter
feedback. By itself this change would increase precompiled snapshot size by
~20%.
 - Lower size threshold for always-inline.
 - Lower size threshold for never-inline.
 - Lower max inlining depth.

dart2js ARM precompiled snapshot: 23847465 => 25436213 (+6.67%)
--noopt benchmarks: geom mean +5.61% (ARM Cortex A53)

BUG=http://dartbug.com/25097
R=fschneider@google.com, srdjan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/899046e4fc88aeb57db68c660e46026c4931bc30
==========

[rmacnak, 2016-01-06 00:25:26]

Committed patchset #1 (id:1) manually as
899046e4fc88aeb57db68c660e46026c4931bc30 (presubmit successful).