Issue 155615: Modify ARAB to use simpler data types in FillBuffer() calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155615: Modify ARAB to use simpler data types in FillBuffer() calls. (Closed)

Created:
11 years, 5 months ago by kylep

Modified:
9 years, 7 months ago

Reviewers:
awong, scherkus (not reviewing)

CC:
chromium-reviews_googlegroups.com, scherkus (not reviewing), fbarchard, awong, kylep, Alpha Left Google

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Modify ARAB to use simpler data types in FillBuffer() calls. BUG=16011 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20892

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -33 lines)			Patch
M	media/filters/audio_renderer_algorithm_base.h	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	media/filters/audio_renderer_algorithm_default.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	media/filters/audio_renderer_algorithm_default.cc	View	1	3 chunks	+5 lines, -9 lines	0 comments	Download
M	media/filters/audio_renderer_algorithm_ola.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	media/filters/audio_renderer_algorithm_ola.cc	View		4 chunks	+7 lines, -9 lines	0 comments	Download
M	media/tools/wav_ola_test.cc	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

kylep

So using DataBuffers might not have been the best idea. It's somewhat unclear how all ...

11 years, 5 months ago (2009-07-16 06:02:54 UTC) #1

scherkus (not reviewing)

11 years, 5 months ago (2009-07-16 19:13:33 UTC) #2

LGTM

nice cleanup removing the headers and stuff