Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1556133002: Shutdown the sandbox MessageServer before deleting it. (Closed)

Created:
4 years, 11 months ago by Robert Sesek
Modified:
4 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shutdown the sandbox MessageServer before deleting it. This prevents incoming messages from being processed while the object is being destructed. BUG=573489 R=thakis@chromium.org Committed: https://crrev.com/e7adaa4fe759a1b5ff7e31b61ef90c0b29ab1853 Cr-Commit-Position: refs/heads/master@{#368355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M sandbox/mac/launchd_interception_server.cc View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/mac/mach_message_server.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/mac/mach_message_server.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M sandbox/mac/message_server.h View 1 chunk +5 lines, -0 lines 0 comments Download
M sandbox/mac/xpc_message_server.h View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/mac/xpc_message_server.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Robert Sesek
4 years, 11 months ago (2016-01-04 21:46:17 UTC) #1
Robert Sesek
ping
4 years, 11 months ago (2016-01-08 15:48:37 UTC) #2
Nico
rs-lgtm Sorry, completely missed this.
4 years, 11 months ago (2016-01-08 15:53:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556133002/1
4 years, 11 months ago (2016-01-08 16:34:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 17:04:27 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 17:06:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7adaa4fe759a1b5ff7e31b61ef90c0b29ab1853
Cr-Commit-Position: refs/heads/master@{#368355}

Powered by Google App Engine
This is Rietveld 408576698