Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1556123003: Add some forgotten test cases to summary_test. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add some forgotten test cases to summary_test. These test cases should have been included in commit e626abcebc2c0ad6eb947790063fea6efda2991d. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/c30e64ea4b79df14d52f5ab88a5e86b35b4b1edb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M pkg/analyzer/test/src/summary/summary_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-04 23:42:21 UTC) #2
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-04 23:46:48 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-04 23:58:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c30e64ea4b79df14d52f5ab88a5e86b35b4b1edb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698