Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1556103002:
Add Startup.SystemUptime histogram. (Closed)
DescriptionAdd Startup.SystemUptime histogram.
This histogram shows the time elapsed between system boot and Chrome
browser process launch.
BUG=547794
Committed: https://crrev.com/4d7f4c714632ff61761eb37587a39958adb6dac8
Cr-Commit-Position: refs/heads/master@{#367832}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Rename histogram function. #
Total comments: 2
Patch Set 3 : Mention where the histogram is logged in histograms.xml. #Patch Set 4 : Rebase. #Patch Set 5 : Fix test error on Android. #Patch Set 6 : Fix test error on Android. #
Messages
Total messages: 23 (11 generated)
fdoray@chromium.org changed reviewers: + asvitkine@chromium.org, gab@chromium.org
Could you review this CL? Thanks.
lgtm % naming suggestions https://codereview.chromium.org/1556103002/diff/1/components/startup_metric_u... File components/startup_metric_utils/browser/startup_metric_utils.cc (right): https://codereview.chromium.org/1556103002/diff/1/components/startup_metric_u... components/startup_metric_utils/browser/startup_metric_utils.cc:136: base::TimeDelta GetStartupUptime() { GetSystemUptimeOnProcessLaunch() ? https://codereview.chromium.org/1556103002/diff/1/components/startup_metric_u... components/startup_metric_utils/browser/startup_metric_utils.cc:147: "Startup.Uptime", GetStartupUptime()); "Startup.SystemUptime" ? (i.e. to make it clear it's the system's uptime)
gab@: Done. asvitkine@: Can you review this CL? Thanks. https://codereview.chromium.org/1556103002/diff/1/components/startup_metric_u... File components/startup_metric_utils/browser/startup_metric_utils.cc (right): https://codereview.chromium.org/1556103002/diff/1/components/startup_metric_u... components/startup_metric_utils/browser/startup_metric_utils.cc:136: base::TimeDelta GetStartupUptime() { On 2016/01/05 15:10:00, gab wrote: > GetSystemUptimeOnProcessLaunch() ? Done. https://codereview.chromium.org/1556103002/diff/1/components/startup_metric_u... components/startup_metric_utils/browser/startup_metric_utils.cc:147: "Startup.Uptime", GetStartupUptime()); On 2016/01/05 15:10:00, gab wrote: > "Startup.SystemUptime" ? (i.e. to make it clear it's the system's uptime) Done.
lgtm % comment https://codereview.chromium.org/1556103002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1556103002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:46946: + The time elapsed between system boot and Chrome browser process launch. Mention when it's logged.
Description was changed from ========== Add Startup.Uptime histogram. This histogram shows the time elapsed between system boot and Chrome browser process launch. BUG=547794 ========== to ========== Add Startup.SystemUptime histogram. This histogram shows the time elapsed between system boot and Chrome browser process launch. BUG=547794 ==========
https://codereview.chromium.org/1556103002/diff/20001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1556103002/diff/20001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:46946: + The time elapsed between system boot and Chrome browser process launch. On 2016/01/05 16:09:24, Alexei Svitkine wrote: > Mention when it's logged. Done.
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org, asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/1556103002/#ps60001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556103002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556103002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556103002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556103002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org, asvitkine@chromium.org Link to the patchset: https://codereview.chromium.org/1556103002/#ps100001 (title: "Fix test error on Android.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556103002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556103002/100001
Message was sent while issue was closed.
Description was changed from ========== Add Startup.SystemUptime histogram. This histogram shows the time elapsed between system boot and Chrome browser process launch. BUG=547794 ========== to ========== Add Startup.SystemUptime histogram. This histogram shows the time elapsed between system boot and Chrome browser process launch. BUG=547794 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Add Startup.SystemUptime histogram. This histogram shows the time elapsed between system boot and Chrome browser process launch. BUG=547794 ========== to ========== Add Startup.SystemUptime histogram. This histogram shows the time elapsed between system boot and Chrome browser process launch. BUG=547794 Committed: https://crrev.com/4d7f4c714632ff61761eb37587a39958adb6dac8 Cr-Commit-Position: refs/heads/master@{#367832} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/4d7f4c714632ff61761eb37587a39958adb6dac8 Cr-Commit-Position: refs/heads/master@{#367832} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
