Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1556063004: Fix "PPC: Use register arguments for RestParamAccessStub". (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix "PPC: Use register arguments for RestParamAccessStub". Fix build break. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/918e66d5a3762771179ccb98d6a21263d1272238 Cr-Commit-Position: refs/heads/master@{#33099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556063004/1
4 years, 11 months ago (2016-01-04 21:22:00 UTC) #2
MTBrandyberry
4 years, 11 months ago (2016-01-04 21:22:17 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 21:47:34 UTC) #5
MTBrandyberry
Still need a review on this one.
4 years, 11 months ago (2016-01-04 22:41:58 UTC) #6
michael_dawson
On 2016/01/04 22:41:58, mtbrandyberry wrote: > Still need a review on this one. lgtm.
4 years, 11 months ago (2016-01-04 22:48:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556063004/1
4 years, 11 months ago (2016-01-04 22:49:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 22:50:44 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 22:51:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/918e66d5a3762771179ccb98d6a21263d1272238
Cr-Commit-Position: refs/heads/master@{#33099}

Powered by Google App Engine
This is Rietveld 408576698