Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 1556043009: cc: Do not refcount SkNullGLContext (Closed)

Created:
4 years, 11 months ago by Kimmo Kinnunen
Modified:
4 years, 11 months ago
Reviewers:
Ian Vollick, vollick1
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, vmpstr+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, danakj, blink-reviews-platform-graphics_chromium.org, Rik, Stephen Chennney, blink-reviews, f(malita), cc-bugs_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Do not refcount SkNullGLContext Use SkNullGLContext with normal ownership semantics instead of refcount semantics. This allows SkGLContext to be changed from refcounted object to normally owned object. Also calls different, non-deprecated constructor for the class. BUG=skia:2992 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/d233bea10898261c3fee357a619a7afef0254bcc Cr-Commit-Position: refs/heads/master@{#367596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M cc/test/test_context_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Kimmo Kinnunen
4 years, 11 months ago (2016-01-05 14:10:24 UTC) #3
Ian Vollick
On 2016/01/05 14:10:24, Kimmo Kinnunen wrote: lgtm.
4 years, 11 months ago (2016-01-05 14:30:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556043009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556043009/1
4 years, 11 months ago (2016-01-05 17:32:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 18:54:45 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 18:55:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d233bea10898261c3fee357a619a7afef0254bcc
Cr-Commit-Position: refs/heads/master@{#367596}

Powered by Google App Engine
This is Rietveld 408576698