Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1556043005: Fix build break after 6d829e9af7d7630422d8095747905015d347b3be. (Closed)

Created:
4 years, 11 months ago by Robert Sesek
Modified:
4 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Fix build break after 6d829e9af7d7630422d8095747905015d347b3be. ../../handler/crash_report_upload_thread.cc:142:7: error: field 'database_' will be initialized after field 'thread_' [-Werror,-Wreorder] database_(database), ^ 1 error generated. And: ..\util\thread\worker_thread_test.cc(25) : warning C4244: 'initializing' : conversion from 'double' to 'const uint64_t', possible loss of data BUG=crashpad:22 R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5e244711888bc215415d58ab21704d4373fff055

Patch Set 1 #

Patch Set 2 : Windows #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M handler/crash_report_upload_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M util/thread/worker_thread_test.cc View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 6 (2 generated)
Robert Sesek
4 years, 11 months ago (2016-01-04 22:16:40 UTC) #1
Mark Mentovai
LGTM
4 years, 11 months ago (2016-01-04 22:20:37 UTC) #2
Robert Sesek
https://codereview.chromium.org/1556043005/diff/20001/util/thread/worker_thread_test.cc File util/thread/worker_thread_test.cc (right): https://codereview.chromium.org/1556043005/diff/20001/util/thread/worker_thread_test.cc#newcode25 util/thread/worker_thread_test.cc:25: const uint64_t kNanosecondsPerSecond = static_cast<uint64_t>(1E9); Also had to add ...
4 years, 11 months ago (2016-01-04 22:26:23 UTC) #4
Robert Sesek
4 years, 11 months ago (2016-01-04 22:42:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5e244711888bc215415d58ab21704d4373fff055 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698