Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Issue 1556023002: Android devices: wait for 100% charge (Closed)

Created:
4 years, 11 months ago by borenet
Modified:
4 years, 11 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Android devices: wait for 100% charge Some devices are getting pretty low by the end of the build (3%). No reason to cut it close, bump to 100% charge. This will cause some devices to sit for a while as they charge up. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556023002 Committed: https://skia.googlesource.com/skia/+/50850b152fce606f2015facf287f04224e647a9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M platform_tools/android/bin/adb_wait_for_device View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
borenet
4 years, 11 months ago (2016-01-04 17:28:23 UTC) #4
dogben
lgtm We'll get an alert if the device takes more than 2 hours to charge, ...
4 years, 11 months ago (2016-01-04 18:26:36 UTC) #5
borenet
On 2016/01/04 18:26:36, Ben Wagner wrote: > lgtm > > We'll get an alert if ...
4 years, 11 months ago (2016-01-04 18:27:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556023002/1
4 years, 11 months ago (2016-01-04 18:27:53 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 18:44:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/50850b152fce606f2015facf287f04224e647a9c

Powered by Google App Engine
This is Rietveld 408576698