Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: net/socket/client_socket_pool_base_unittest.cc

Issue 1556018: Add support for attaching custom parameters to NetLog events. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address willchan's comments Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_service.cc ('k') | net/socket_stream/socket_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_pool_base_unittest.cc
===================================================================
--- net/socket/client_socket_pool_base_unittest.cc (revision 44049)
+++ net/socket/client_socket_pool_base_unittest.cc (working copy)
@@ -835,7 +835,7 @@
InitHandle(&handle, "foo", kDefaultPriority, &callback, pool_,
NULL));
- // But if we wait for it, the released idle sockets will be closed in
+ // But if we wait for it, the released idle sockets will be closed in
// preference of the waiting request.
EXPECT_EQ(OK, callback.WaitForResult());
@@ -1407,7 +1407,7 @@
EXPECT_EQ(OK, rv);
EXPECT_TRUE(req.handle()->is_reused());
EXPECT_TRUE(LogContainsEntryWithType(
- log.entries(), 1, NetLog::Entry::TYPE_STRING_LITERAL));
+ log.entries(), 1, NetLog::TYPE_TODO_STRING_LITERAL));
}
// Make sure that we process all pending requests even when we're stalling
« no previous file with comments | « net/proxy/proxy_service.cc ('k') | net/socket_stream/socket_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698