Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: chrome/browser/net/chrome_net_log.cc

Issue 1556018: Add support for attaching custom parameters to NetLog events. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address willchan's comments Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/net/chrome_net_log.h ('k') | chrome/browser/net/passive_log_collector.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/net/chrome_net_log.h" 5 #include "chrome/browser/net/chrome_net_log.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
11 #include "chrome/browser/chrome_thread.h" 11 #include "chrome/browser/chrome_thread.h"
12 #include "chrome/browser/net/passive_log_collector.h" 12 #include "chrome/browser/net/passive_log_collector.h"
13 13
14 ChromeNetLog::ChromeNetLog() 14 ChromeNetLog::ChromeNetLog()
15 : next_id_(0), 15 : next_id_(0),
16 passive_collector_(new PassiveLogCollector) { 16 passive_collector_(new PassiveLogCollector) {
17 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO)); 17 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
18 AddObserver(passive_collector_.get()); 18 AddObserver(passive_collector_.get());
19 } 19 }
20 20
21 ChromeNetLog::~ChromeNetLog() { 21 ChromeNetLog::~ChromeNetLog() {
22 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO)); 22 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
23 RemoveObserver(passive_collector_.get()); 23 RemoveObserver(passive_collector_.get());
24 } 24 }
25 25
26 void ChromeNetLog::AddEntry(const Entry& entry) { 26 void ChromeNetLog::AddEntry(EventType type,
27 const base::TimeTicks& time,
28 const Source& source,
29 EventPhase phase,
30 EventParameters* extra_parameters) {
27 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO)); 31 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
28 32
29 // Notify all of the log observers. 33 // Notify all of the log observers.
30 FOR_EACH_OBSERVER(Observer, observers_, OnAddEntry(entry)); 34 FOR_EACH_OBSERVER(Observer, observers_,
35 OnAddEntry(type, time, source, phase, extra_parameters));
31 } 36 }
32 37
33 int ChromeNetLog::NextID() { 38 int ChromeNetLog::NextID() {
34 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO)); 39 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
35 return next_id_++; 40 return next_id_++;
36 } 41 }
37 42
38 bool ChromeNetLog::HasListener() const { 43 bool ChromeNetLog::HasListener() const {
39 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO)); 44 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
40 // TODO(eroman): Hack to get refactor working. 45 // TODO(eroman): Hack to get refactor working.
41 return passive_collector_->url_request_tracker()->IsUnbounded(); 46 return passive_collector_->url_request_tracker()->IsUnbounded();
42 } 47 }
43 48
44 void ChromeNetLog::AddObserver(Observer* observer) { 49 void ChromeNetLog::AddObserver(Observer* observer) {
45 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO)); 50 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
46 observers_.AddObserver(observer); 51 observers_.AddObserver(observer);
47 } 52 }
48 53
49 void ChromeNetLog::RemoveObserver(Observer* observer) { 54 void ChromeNetLog::RemoveObserver(Observer* observer) {
50 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO)); 55 DCHECK(ChromeThread::CurrentlyOn(ChromeThread::IO));
51 observers_.RemoveObserver(observer); 56 observers_.RemoveObserver(observer);
52 } 57 }
53 58
OLDNEW
« no previous file with comments | « chrome/browser/net/chrome_net_log.h ('k') | chrome/browser/net/passive_log_collector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698