Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: src/gpu/GrDrawingManager.cpp

Issue 1555993005: Add assert that memory pool is empty when GrTextBlobCache frees (Closed) Base URL: https://skia.googlesource.com/skia.git@minor-mempoolfix
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/text/GrTextBlobCache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrDrawingManager.cpp
diff --git a/src/gpu/GrDrawingManager.cpp b/src/gpu/GrDrawingManager.cpp
index 7aa0fdbe0a281094edff5936373012cc03353c91..2a27f6aac453557aca310f1629563d01929f6348 100644
--- a/src/gpu/GrDrawingManager.cpp
+++ b/src/gpu/GrDrawingManager.cpp
@@ -20,6 +20,9 @@ void GrDrawingManager::cleanup() {
fDrawTargets[i]->makeClosed(); // no drawTarget should receive a new command after this
fDrawTargets[i]->clearRT();
+ // We shouldn't need to do this, but it turns out some clients still hold onto drawtargets
+ // after a cleanup
+ fDrawTargets[i]->reset();
fDrawTargets[i]->unref();
}
« no previous file with comments | « no previous file | src/gpu/text/GrTextBlobCache.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698