Adds backoff and Min Wait Duration compliance to Protocolmanager pver4 handlers.

chrome/browser/safe_browsing/protocol_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 
 #include <vector>
 
 #include "base/base64.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/stringprintf.h"
@@ skipping 236 matching lines @@
   pm->HandleGetHashError(now);
   EXPECT_EQ(6U, pm->gethash_error_count_);
   EXPECT_TRUE(pm->next_gethash_time_ == now + TimeDelta::FromMinutes(480));
 
   // 7 errors.
   pm->HandleGetHashError(now);
   EXPECT_EQ(7U, pm->gethash_error_count_);
   EXPECT_TRUE(pm->next_gethash_time_== now + TimeDelta::FromMinutes(480));
 }
 
+TEST_F(SafeBrowsingProtocolManagerTest, TestGetV4HashBackOffTimes) {
+  scoped_ptr<SafeBrowsingProtocolManager> pm(CreateProtocolManager(NULL));
+
+  // No errors or back off time yet.
+  EXPECT_EQ(0U, pm->gethash_v4_error_count_);
+  EXPECT_EQ(1U, pm->gethash_v4_back_off_mult_);
+  Time now = Time::Now();
+  EXPECT_TRUE(pm->next_gethash_v4_time_ < now);
+
+  // 1 error.
+  pm->HandleGetHashV4Error(now);
+  EXPECT_EQ(1U, pm->gethash_v4_error_count_);
+  EXPECT_EQ(1U, pm->gethash_v4_back_off_mult_);
+  EXPECT_TRUE(pm->next_gethash_v4_time_ >= now + TimeDelta::FromMinutes(15) &&

[Nathan Parker, 2016/01/07 06:06:58]

These should probably use EXPECT_GE and EXPECT_LE, so that if they fail it'll
give the real values rather than just "not true"

[kcarattini, 2016/01/07 06:48:53]

Done.

+              pm->next_gethash_v4_time_ <= now + TimeDelta::FromMinutes(30));
+
+  // 2 errors.
+  pm->HandleGetHashV4Error(now);
+  EXPECT_EQ(2U, pm->gethash_v4_error_count_);
+  EXPECT_EQ(2U, pm->gethash_v4_back_off_mult_);
+  EXPECT_TRUE(pm->next_gethash_v4_time_ >= now + TimeDelta::FromMinutes(30) &&
+              pm->next_gethash_v4_time_ <= now + TimeDelta::FromMinutes(60));
+
+  // 3 errors.
+  pm->HandleGetHashV4Error(now);
+  EXPECT_EQ(3U, pm->gethash_v4_error_count_);
+  EXPECT_EQ(4U, pm->gethash_v4_back_off_mult_);
+  EXPECT_TRUE(pm->next_gethash_v4_time_ >= now + TimeDelta::FromMinutes(60) &&
+              pm->next_gethash_v4_time_ <= now + TimeDelta::FromMinutes(120));
+
+  // 4 errors.
+  pm->HandleGetHashV4Error(now);
+  EXPECT_EQ(4U, pm->gethash_v4_error_count_);
+  EXPECT_EQ(8U, pm->gethash_v4_back_off_mult_);
+  EXPECT_TRUE(pm->next_gethash_v4_time_ >= now + TimeDelta::FromMinutes(120) &&
+              pm->next_gethash_v4_time_ <= now + TimeDelta::FromMinutes(240));
+
+  // 5 errors.
+  pm->HandleGetHashV4Error(now);
+  EXPECT_EQ(5U, pm->gethash_v4_error_count_);
+  EXPECT_EQ(16U, pm->gethash_v4_back_off_mult_);
+  EXPECT_TRUE(pm->next_gethash_v4_time_ >= now + TimeDelta::FromMinutes(240) &&
+              pm->next_gethash_v4_time_ <= now + TimeDelta::FromMinutes(480));
+
+  // 6 errors.
+  pm->HandleGetHashV4Error(now);
+  EXPECT_EQ(6U, pm->gethash_v4_error_count_);
+  EXPECT_EQ(32U, pm->gethash_v4_back_off_mult_);
+  EXPECT_TRUE(pm->next_gethash_v4_time_ >= now + TimeDelta::FromMinutes(480) &&
+              pm->next_gethash_v4_time_ <= now + TimeDelta::FromMinutes(960));
+
+  // 7 errors.
+  pm->HandleGetHashV4Error(now);
+  EXPECT_EQ(7U, pm->gethash_v4_error_count_);
+  EXPECT_EQ(64U, pm->gethash_v4_back_off_mult_);
+  EXPECT_TRUE(pm->next_gethash_v4_time_ >= now + TimeDelta::FromMinutes(960) &&
+              pm->next_gethash_v4_time_ <= now + TimeDelta::FromMinutes(1920));
+
+  // 8 errors, reached max backoff.
+  pm->HandleGetHashV4Error(now);
+  EXPECT_EQ(8U, pm->gethash_v4_error_count_);
+  EXPECT_EQ(128U, pm->gethash_v4_back_off_mult_);
+  EXPECT_TRUE(pm->next_gethash_v4_time_ == now + TimeDelta::FromHours(24));

[Nathan Parker, 2016/01/07 06:06:58]

EXPECT_EQ

[kcarattini, 2016/01/07 06:48:53]

Done.

+}
+
 TEST_F(SafeBrowsingProtocolManagerTest, TestGetHashUrl) {
   scoped_ptr<SafeBrowsingProtocolManager> pm(CreateProtocolManager(NULL));
 
   EXPECT_EQ(
       "https://prefix.com/foo/gethash?client=unittest&appver=1.0&"
       "pver=3.0" +
           key_param_ + "&ext=0",
       pm->GetHashUrl(false).spec());
 
   pm->set_additional_query(kAdditionalQuery);
@@ skipping 1042 matching lines @@
 
   EXPECT_FALSE(pm->IsUpdateScheduled());
 
   // Invoke the AddChunksCallback to finish the update.
   runner->RunPendingTasks();
 
   EXPECT_TRUE(pm->IsUpdateScheduled());
 }
 
 }  // namespace safe_browsing