build_tools/test_build_tools.py - Issue 1555913002: Build gtest from source rather than using SDK-provided version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_tools/test_build_tools.py

Issue 1555913002: Build gtest from source rather than using SDK-provided version (Closed) Base URL: https://chromium.googlesource.com/webports.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build_tools/test_build_tools.py

diff --git a/build_tools/test_build_tools.py b/build_tools/test_build_tools.py

index 5712c447a39982346daaaacbd98c8441210eb252..8ff9ae14a369383b4b4cd92464b4663ad3cf6187 100644

--- a/build_tools/test_build_tools.py

+++ b/build_tools/test_build_tools.py

@@ -118,8 +118,8 @@ class TestFindEffectedPackages(unittest.TestCase):

# list.

self.assertEqual(

find_effected_packages(['ports/hello', 'ports/ruby'], True, None),

- ['hello', 'corelibs', 'glibc-compat', 'ncurses', 'readline', 'zlib',

- 'ruby', 'libtar', 'nacl-spawn', 'ruby-ppapi'])

+ ['hello', 'corelibs', 'gtest', 'glibc-compat', 'ncurses', 'readline',

+ 'zlib', 'ruby', 'libtar', 'nacl-spawn', 'ruby-ppapi'])

def test_filter(self):

effected = find_effected_packages(['ports/corelibs'], True,

« no previous file with comments | « build_tools/partition6.txt ('k') | ports/corelibs/build.sh » ('j') | no next file with comments »