Issue 155588: GTK Themes: Tint throbbers like we tint all other buttons in the interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155588: GTK Themes: Tint throbbers like we tint all other buttons in the interface. (Closed)

Created:
11 years, 5 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, James Hawkins, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

GTK Themes: Tint throbbers like we tint all other buttons in the interface. http://crbug.com/13967 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20799

Patch Set 1 #

Patch Set 2 : Minimize patch #

Total comments: 2

Patch Set 3 : Changes for tony #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -42 lines)			Patch
M	chrome/browser/browser_theme_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/tabs/dragged_tab_gtk.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/tabs/tab_gtk.h	View	1 2	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/tabs/tab_gtk.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/tabs/tab_renderer_gtk.h	View		5 chunks	+19 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_renderer_gtk.cc	View		6 chunks	+44 lines, -34 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_strip_gtk.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_strip_gtk.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

11 years, 5 months ago (2009-07-15 20:54:31 UTC) #2

LGTM, 2 small questions.

http://codereview.chromium.org/155588/diff/1001/20
File chrome/browser/browser_theme_provider.cc (right):

http://codereview.chromium.org/155588/diff/1001/20#newcode135
Line 135: IDR_THROBBER, IDR_THROBBER_WAITING, IDR_THROBBER_LIGHT
I assume Glen was planning to add these anyway?

http://codereview.chromium.org/155588/diff/1001/22
File chrome/browser/gtk/tabs/tab_gtk.cc (right):

http://codereview.chromium.org/155588/diff/1001/22#newcode111
Line 111: : TabRendererGtk(theme_provider),
It looks like the TabDelegate implementation (TabStripGtk) already has a pointer
tot he theme_provider.  Maybe we can just add the theme provider to the
TabDelegate interface?

Expand Messages | Collapse Messages