mac and ios: Build third-party code with -Wall.

mac and ios: Build third-party code with -Wall.

This lands the mac and ios build/common.gypi bits of
https://codereview.chromium.org/1551753002/ (reviewed there)

BUG=573250
R=thestig@chromium.org
TBR=thestig@chromium.org

Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc
Cr-Commit-Position: refs/heads/master@{#367255}

Committed: https://crrev.com/de5c041e67fa5abee83359b9346ca4896f1723ca
Cr-Commit-Position: refs/heads/master@{#367263}

[Nico, 2015-12-31 22:09:49]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-12-31 22:09:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555843002/1

[Lei Zhang, 2015-12-31 23:04:37]

lgtm

[commit-bot: I haz the power, 2016-01-01 00:46:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-01 00:46:24]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2016-01-01 02:13:17]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-01-01 02:13:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555843002/1

[Nico, 2016-01-01 03:55:01]

Description was changed from

==========
mac and ios: Build third-party code with -Wall.

This lands the mac and ios build/common.gypi bits of
https://codereview.chromium.org/1551753002/ (reviewed there)

BUG=573250
TBR=thestig@chromium.org
==========

to

==========
mac and ios: Build third-party code with -Wall.

This lands the mac and ios build/common.gypi bits of
https://codereview.chromium.org/1551753002/ (reviewed there)

BUG=573250
R=thestig@chromium.org
TBR=thestig@chromium.org
==========

[Nico, 2016-01-01 03:55:20]

Committed patchset #1 (id:1) to pending queue manually as
52eb9a406cc872dc1cd3b8e5d43785f5e1005e6e (presubmit successful).

[commit-bot: I haz the power, 2016-01-01 03:55:39]

Description was changed from

==========
mac and ios: Build third-party code with -Wall.

This lands the mac and ios build/common.gypi bits of
https://codereview.chromium.org/1551753002/ (reviewed there)

BUG=573250
R=thestig@chromium.org
TBR=thestig@chromium.org
==========

to

==========
mac and ios: Build third-party code with -Wall.

This lands the mac and ios build/common.gypi bits of
https://codereview.chromium.org/1551753002/ (reviewed there)

BUG=573250
R=thestig@chromium.org
TBR=thestig@chromium.org

Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc
Cr-Commit-Position: refs/heads/master@{#367255}
==========

[commit-bot: I haz the power, 2016-01-01 03:55:39]

Patchset 1 (id:??) landed as
https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc
Cr-Commit-Position: refs/heads/master@{#367255}

[sof, 2016-01-01 06:16:53]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1553943002/ by sigbjornf@opera.com.

The reason for reverting is: ios_Device builder isn't quite ready for -Wall,

 http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/33368

breaking compilation..

[Nico, 2016-01-01 06:30:52]

Thanks for the revert! Why is that configuration not on the cq... :-/
On Jan 1, 2016 1:16 AM, <sigbjornf@opera.com> wrote:

> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1553943002/ by sigbjornf@opera.com.
>
> The reason for reverting is: ios_Device builder isn't quite ready for
> -Wall,
>
>  http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/33368
>
> breaking compilation..
>
> https://codereview.chromium.org/1555843002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-01-01 17:16:19]

Filed https://code.google.com/p/chromium/issues/detail?id=573598 for the missing
commit queue coverage.

[Nico, 2016-01-01 18:51:06]

Description was changed from

==========
mac and ios: Build third-party code with -Wall.

This lands the mac and ios build/common.gypi bits of
https://codereview.chromium.org/1551753002/ (reviewed there)

BUG=573250
R=thestig@chromium.org
TBR=thestig@chromium.org

Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc
Cr-Commit-Position: refs/heads/master@{#367255}
==========

to

==========
mac and ios: Build third-party code with -Wall.

This lands the mac and ios build/common.gypi bits of
https://codereview.chromium.org/1551753002/ (reviewed there)

BUG=573250
R=thestig@chromium.org
TBR=thestig@chromium.org

Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc
Cr-Commit-Position: refs/heads/master@{#367255}
==========

[Nico, 2016-01-01 18:51:59]

Relanding; with patch set 2 I could build all.xcodeproj for ios successfully.

[Nico, 2016-01-01 18:55:45]

Description was changed from

==========
mac and ios: Build third-party code with -Wall.

This lands the mac and ios build/common.gypi bits of
https://codereview.chromium.org/1551753002/ (reviewed there)

BUG=573250
R=thestig@chromium.org
TBR=thestig@chromium.org

Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc
Cr-Commit-Position: refs/heads/master@{#367255}
==========

to

==========
mac and ios: Build third-party code with -Wall.

This lands the mac and ios build/common.gypi bits of
https://codereview.chromium.org/1551753002/ (reviewed there)

BUG=573250
R=thestig@chromium.org
TBR=thestig@chromium.org

Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc
Cr-Commit-Position: refs/heads/master@{#367255}
==========

[Nico, 2016-01-01 18:55:46]

Committed patchset #2 (id:20001) to pending queue manually as
4a7e4dd03543a19d8af2b12d91a45d48f5c7d331 (presubmit successful).

[commit-bot: I haz the power, 2016-01-01 18:56:45]

Description was changed from

==========
mac and ios: Build third-party code with -Wall.

This lands the mac and ios build/common.gypi bits of
https://codereview.chromium.org/1551753002/ (reviewed there)

BUG=573250
R=thestig@chromium.org
TBR=thestig@chromium.org

Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc
Cr-Commit-Position: refs/heads/master@{#367255}
==========

to

==========
mac and ios: Build third-party code with -Wall.

This lands the mac and ios build/common.gypi bits of
https://codereview.chromium.org/1551753002/ (reviewed there)

BUG=573250
R=thestig@chromium.org
TBR=thestig@chromium.org

Committed: https://crrev.com/9830789346abd3d8211deff1ebe7a7f5753ba3fc
Cr-Commit-Position: refs/heads/master@{#367255}

Committed: https://crrev.com/de5c041e67fa5abee83359b9346ca4896f1723ca
Cr-Commit-Position: refs/heads/master@{#367263}
==========

[commit-bot: I haz the power, 2016-01-01 18:56:46]

Patchset 2 (id:??) landed as
https://crrev.com/de5c041e67fa5abee83359b9346ca4896f1723ca
Cr-Commit-Position: refs/heads/master@{#367263}

[Lei Zhang, 2016-01-01 19:04:32]

lgtm

[Lei Zhang, 2016-01-01 19:11:39]

Oh, but the GPU Mac Builder went red too. Didn't realize that was a tree closer.

[sof, 2016-01-01 20:13:26]

On 2016/01/01 19:11:39, Lei Zhang wrote:
> Oh, but the GPU Mac Builder went red too. Didn't realize that was a tree
closer.

CQ_INCLUDE_TRYBOTS to the rescue, hopefully. I'll leave r367263 alone & assume
one of you have the time to address the breakage.

[Nico, 2016-01-01 20:27:38]

On 2016/01/01 20:13:26, sof wrote:
> On 2016/01/01 19:11:39, Lei Zhang wrote:
> > Oh, but the GPU Mac Builder went red too. Didn't realize that was a tree
> closer.
> 
> CQ_INCLUDE_TRYBOTS to the rescue, hopefully. I'll leave r367263 alone & assume
> one of you have the time to address the breakage.

I'll look later today thanks :-(

[Geoff Lang, 2016-01-01 23:03:05]

On 2016/01/01 20:27:38, Nico wrote:
> On 2016/01/01 20:13:26, sof wrote:
> > On 2016/01/01 19:11:39, Lei Zhang wrote:
> > > Oh, but the GPU Mac Builder went red too. Didn't realize that was a tree
> > closer.
> > 
> > CQ_INCLUDE_TRYBOTS to the rescue, hopefully. I'll leave r367263 alone &
assume
> > one of you have the time to address the breakage.
> 
> I'll look later today thanks :-(

Going to revert this again.  Mac GPU bots are all failing compilation.

[Geoff Lang, 2016-01-01 23:03:41]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1556843002/ by geofflang@chromium.org.

The reason for reverting is: Fails compilation on Mac GPU bots..

[Nico, 2016-01-01 23:13:35]

On 2016/01/01 23:03:05, Geoff Lang wrote:
> On 2016/01/01 20:27:38, Nico wrote:
> > On 2016/01/01 20:13:26, sof wrote:
> > > On 2016/01/01 19:11:39, Lei Zhang wrote:
> > > > Oh, but the GPU Mac Builder went red too. Didn't realize that was a tree
> > > closer.
> > > 
> > > CQ_INCLUDE_TRYBOTS to the rescue, hopefully. I'll leave r367263 alone &
> assume
> > > one of you have the time to address the breakage.
> > 
> > I'll look later today thanks :-(
> 
> Going to revert this again.  Mac GPU bots are all failing compilation.

I filed https://code.google.com/p/chromium/issues/detail?id=573608 for the gpu
bots closing the tree. Bots without cq bots shouldn't generally caused reverts;
especially when I said that I'd look (which I will now).